src/client/windows/tests/crash_generation_app/crash_generation_app.cc - Issue 1353893002: Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/client/windows/tests/crash_generation_app/crash_generation_app.cc

Issue 1353893002: Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/client/windows/tests/crash_generation_app/crash_generation_app.cc

diff --git a/src/client/windows/tests/crash_generation_app/crash_generation_app.cc b/src/client/windows/tests/crash_generation_app/crash_generation_app.cc

index ad395d6c0ac041517e5d48e392e4d5d6b59f77a9..0d837e521d0b101772432d3a19db96f367952e96 100644

--- a/src/client/windows/tests/crash_generation_app/crash_generation_app.cc

+++ b/src/client/windows/tests/crash_generation_app/crash_generation_app.cc

@@ -73,7 +73,7 @@ BOOL InitInstance(HINSTANCE, int);

LRESULT CALLBACK WndProc(HWND, UINT, WPARAM, LPARAM);

INT_PTR CALLBACK About(HWND, UINT, WPARAM, LPARAM);

-static int kCustomInfoCount = 2;

+static size_t kCustomInfoCount = 2;

static CustomInfoEntry kCustomInfoEntries[] = {

CustomInfoEntry(L"prod", L"CrashTestApp"),

CustomInfoEntry(L"ver", L"1.0"),

« no previous file with comments | « no previous file | src/client/windows/unittests/client_tests.gyp » ('j') | src/client/windows/unittests/crash_generation_server_test.cc » ('J')