Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: src/processor/proc_maps_linux.cc

Issue 1353893002: Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/processor/proc_maps_linux.cc
diff --git a/src/processor/proc_maps_linux.cc b/src/processor/proc_maps_linux.cc
index ed1857127ac7291e9fc610c4e4c2f40e40651748..0cd3772e0afefbdb517ca5373d2c07202200caa2 100644
--- a/src/processor/proc_maps_linux.cc
+++ b/src/processor/proc_maps_linux.cc
@@ -34,16 +34,16 @@ bool ParseProcMaps(const std::string& input,
// Split the string by newlines.
std::vector<std::string> lines;
- std::string line = "";
+ std::string l = "";
for (size_t i = 0; i < input.size(); i++) {
if (input[i] != '\n' && input[i] != '\r') {
- line.push_back(input[i]);
- } else if (line.size() > 0) {
- lines.push_back(line);
- line.clear();
+ l.push_back(input[i]);
+ } else if (l.size() > 0) {
+ lines.push_back(l);
+ l.clear();
}
}
- if (line.size() > 0) {
+ if (l.size() > 0) {
BPLOG(ERROR) << "Input doesn't end in newline";
return false;
}
« src/client/windows/unittests/crash_generation_server_test.cc ('K') | « src/processor/minidump.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698