src/client/windows/unittests/crash_generation_server_test.cc - Issue 1353893002: Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/client/windows/unittests/crash_generation_server_test.cc

Issue 1353893002: Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013. (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/client/windows/unittests/crash_generation_server_test.cc

diff --git a/src/client/windows/unittests/crash_generation_server_test.cc b/src/client/windows/unittests/crash_generation_server_test.cc

index cf95d43f00acf649901315faf2aef082b059b217..4cde623c9f9f2d408da2fc499e1f9651a1595f14 100644

--- a/src/client/windows/unittests/crash_generation_server_test.cc

+++ b/src/client/windows/unittests/crash_generation_server_test.cc

@@ -50,7 +50,7 @@ const DWORD kPipeFlagsAndAttributes = SECURITY_IDENTIFICATION |

const DWORD kPipeMode = PIPE_READMODE_MESSAGE;

-int kCustomInfoCount = 2;

+size_t kCustomInfoCount = 2;

Mark Mentovai 2015/09/29 17:40:19 const. Or get rid of this and subsitute arraysize(

google_breakpad::CustomInfoEntry kCustomInfoEntries[] = {

Mark Mentovai 2015/09/29 17:40:20 const

google_breakpad::CustomInfoEntry(L"prod", L"CrashGenerationServerTest"),

« no previous file with comments | « src/client/windows/unittests/client_tests.gyp ('k') | src/google_breakpad/common/breakpad_types.h » ('j') | no next file with comments »