Fix MSVC build (including on 2015), drop some workarounds for MSVC older than 2013.

src/client/windows/unittests/crash_generation_server_test.cc

 // Copyright 2010, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 32 matching lines @@
 
 const DWORD kPipeDesiredAccess = FILE_READ_DATA |
                                  FILE_WRITE_DATA |
                                  FILE_WRITE_ATTRIBUTES;
 
 const DWORD kPipeFlagsAndAttributes = SECURITY_IDENTIFICATION |
                                       SECURITY_SQOS_PRESENT;
 
 const DWORD kPipeMode = PIPE_READMODE_MESSAGE;
 
-int kCustomInfoCount = 2;
+size_t kCustomInfoCount = 2;

[Mark Mentovai, 2015/09/29 17:40:19]

const. Or get rid of this and subsitute arraysize(kCustomInfoEntries) where it’s
used.

 
 google_breakpad::CustomInfoEntry kCustomInfoEntries[] = {

[Mark Mentovai, 2015/09/29 17:40:20]

const

     google_breakpad::CustomInfoEntry(L"prod", L"CrashGenerationServerTest"),
     google_breakpad::CustomInfoEntry(L"ver", L"1.0"),
 };
 
 class CrashGenerationServerTest : public ::testing::Test {
  public:
   CrashGenerationServerTest()
       : crash_generation_server_(kPipeName,
                                  NULL,
                                  CallOnClientConnected, &mock_callbacks_,
@@ skipping 231 matching lines @@
   ASSERT_NO_FATAL_FAILURE(FaultyClient(CLOSE_AFTER_CONNECT));
 
   EXPECT_CALL(mock_callbacks_, OnClientConnected(_));
   ASSERT_NO_FATAL_FAILURE(FaultyClient(NO_FAULT));
 
   // See DoTestFault for an explanation of this line
   ASSERT_NO_FATAL_FAILURE(FaultyClient(CLOSE_AFTER_CONNECT));
 }
 
 }  // anonymous namespace