Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1347943003: Replace GrExtractAlphaFragmentProcessor with DstIn compose processor (Closed)

Created:
5 years, 3 months ago by bsalomon
Modified:
5 years, 3 months ago
Reviewers:
egdaniel, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Replace GrExtractAlphaFragmentProcessor with DstIn compose processor Committed: https://skia.googlesource.com/skia/+/87ba62e67c9ed0c453754a5341255829075c8e22

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move helper to GrFragmentProcessor #

Patch Set 3 : tiny comment update #

Patch Set 4 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -122 lines) Patch
M gm/dcshader.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M gyp/gpu.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/GrFragmentProcessor.h View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
D include/gpu/effects/GrExtractAlphaFragmentProcessor.h View 1 chunk +0 lines, -47 lines 0 comments Download
M src/core/SkBitmapProcShader.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/core/SkLightingShader.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 3 chunks +2 lines, -3 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 1 chunk +7 lines, -0 lines 0 comments Download
D src/gpu/effects/GrExtractAlphaFragmentProcessor.cpp View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
bsalomon
Just a code size reduction.
5 years, 3 months ago (2015-09-16 02:38:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347943003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347943003/1
5 years, 3 months ago (2015-09-16 02:54:59 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-16 03:01:14 UTC) #6
reed1
https://codereview.chromium.org/1347943003/diff/1/include/core/SkShader.h File include/core/SkShader.h (right): https://codereview.chromium.org/1347943003/diff/1/include/core/SkShader.h#newcode441 include/core/SkShader.h:441: static const GrFragmentProcessor* MulFragmentProcesorOuputByInputAlpha( Curious why this is on ...
5 years, 3 months ago (2015-09-16 13:34:27 UTC) #8
bsalomon
https://codereview.chromium.org/1347943003/diff/1/include/core/SkShader.h File include/core/SkShader.h (right): https://codereview.chromium.org/1347943003/diff/1/include/core/SkShader.h#newcode441 include/core/SkShader.h:441: static const GrFragmentProcessor* MulFragmentProcesorOuputByInputAlpha( On 2015/09/16 13:34:27, reed1 wrote: ...
5 years, 3 months ago (2015-09-21 15:29:50 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347943003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347943003/40001
5 years, 3 months ago (2015-09-21 17:37:48 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-21 17:42:28 UTC) #13
bsalomon
On 2015/09/21 17:42:28, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 3 months ago (2015-09-22 13:28:36 UTC) #14
egdaniel
lgtm
5 years, 3 months ago (2015-09-22 13:36:48 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1347943003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1347943003/60001
5 years, 3 months ago (2015-09-22 13:37:24 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-22 13:42:03 UTC) #18
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/87ba62e67c9ed0c453754a5341255829075c8e22

Powered by Google App Engine
This is Rietveld 408576698