src/core/SkLightingShader.cpp - Issue 1347943003: Replace GrExtractAlphaFragmentProcessor with DstIn compose processor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkLightingShader.cpp

Issue 1347943003: Replace GrExtractAlphaFragmentProcessor with DstIn compose processor (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: update comment Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkLightingShader.cpp

diff --git a/src/core/SkLightingShader.cpp b/src/core/SkLightingShader.cpp

index 2907dba7d57f816f273c9cc8fd2694805c14aeba..b23acfdf7d227207a189257004528c6d9a937ce9 100644

--- a/src/core/SkLightingShader.cpp

+++ b/src/core/SkLightingShader.cpp

@@ -131,7 +131,6 @@ private:

#include "GrCoordTransform.h"

#include "GrFragmentProcessor.h"

#include "GrTextureAccess.h"

-#include "effects/GrExtractAlphaFragmentProcessor.h"

#include "gl/GrGLProcessor.h"

#include "gl/builders/GrGLProgramBuilder.h"

#include "SkGr.h"

@@ -401,7 +400,7 @@ const GrFragmentProcessor* SkLightingShaderImpl::asFragmentProcessor(

SkAutoTUnref<const GrFragmentProcessor> inner (

new LightingFP(pdm, diffuseTexture, normalTexture, diffM, normM, diffParams, normParams,

fLights, fInvNormRotation));

- return GrExtractAlphaFragmentProcessor::Create(inner);

+ return GrFragmentProcessor::MulOuputByInputAlpha(inner);

}

#endif

« no previous file with comments | « src/core/SkBitmapProcShader.cpp ('k') | src/effects/SkPerlinNoiseShader.cpp » ('j') | no next file with comments »