Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1332923003: Remove batchtracker (Closed)

Created:
5 years, 3 months ago by joshua.litt
Modified:
5 years, 3 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@latecreatepathprocessor
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 82

Patch Set 3 : tweaks #

Patch Set 4 : feedback inc #

Patch Set 5 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -493 lines) Patch
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 2 4 chunks +6 lines, -12 lines 0 comments Download
M src/gpu/GrGeometryProcessor.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +4 lines, -8 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 2 13 chunks +21 lines, -42 lines 0 comments Download
M src/gpu/GrPathProcessor.h View 1 2 3 4 2 chunks +2 lines, -20 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +4 lines, -59 lines 0 comments Download
M src/gpu/GrPathRendering.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/GrPipelineBuilder.h View 2 chunks +0 lines, -18 lines 0 comments Download
M src/gpu/GrPipelineBuilder.cpp View 1 chunk +0 lines, -11 lines 0 comments Download
M src/gpu/GrPrimitiveProcessor.h View 1 2 3 4 3 chunks +2 lines, -44 lines 0 comments Download
M src/gpu/GrProcOptInfo.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/GrProcOptInfo.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 2 4 chunks +6 lines, -13 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M src/gpu/batches/GrVertexBatch.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/batches/GrVertexBatch.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.h View 1 2 3 chunks +6 lines, -15 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 1 2 3 12 chunks +24 lines, -46 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.h View 1 2 1 chunk +2 lines, -5 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 2 3 4 chunks +7 lines, -15 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 2 3 12 chunks +20 lines, -43 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.h View 1 2 3 chunks +6 lines, -15 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 2 3 12 chunks +19 lines, -37 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLPathProcessor.h View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M src/gpu/gl/GrGLPathProcessor.cpp View 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.h View 1 2 4 chunks +1 line, -6 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLProgramDesc.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Issue 1333273003 Patch 1

Messages

Total messages: 12 (5 generated)
joshualitt
ptal
5 years, 3 months ago (2015-09-10 18:31:20 UTC) #2
bsalomon
https://codereview.chromium.org/1332923003/diff/20001/src/gpu/GrDefaultGeoProcFactory.cpp File src/gpu/GrDefaultGeoProcFactory.cpp (right): https://codereview.chromium.org/1332923003/diff/20001/src/gpu/GrDefaultGeoProcFactory.cpp#newcode181 src/gpu/GrDefaultGeoProcFactory.cpp:181: virtual GrGLPrimitiveProcessor* createGLInstance(const GrGLSLCaps&) const override { -virtual? https://codereview.chromium.org/1332923003/diff/20001/src/gpu/GrOvalRenderer.cpp ...
5 years, 3 months ago (2015-09-10 18:55:32 UTC) #3
joshualitt
feedback inc https://codereview.chromium.org/1332923003/diff/20001/src/gpu/GrDefaultGeoProcFactory.cpp File src/gpu/GrDefaultGeoProcFactory.cpp (right): https://codereview.chromium.org/1332923003/diff/20001/src/gpu/GrDefaultGeoProcFactory.cpp#newcode181 src/gpu/GrDefaultGeoProcFactory.cpp:181: virtual GrGLPrimitiveProcessor* createGLInstance(const GrGLSLCaps&) const override { ...
5 years, 3 months ago (2015-09-10 20:08:06 UTC) #4
bsalomon
lgtm
5 years, 3 months ago (2015-09-10 20:20:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332923003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332923003/60001
5 years, 3 months ago (2015-09-11 13:29:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1332923003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1332923003/80001
5 years, 3 months ago (2015-09-11 13:46:48 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 15:19:38 UTC) #12
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/465283cdf98ed9ab5285ca7b9814e430fca1d452

Powered by Google App Engine
This is Rietveld 408576698