Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1330973002: relnote: Refactor QuicAckFrame::missing_packets to support a change to a (Closed)

Created:
5 years, 3 months ago by ramant (doing other things)
Modified:
5 years, 3 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, Jeremy Dorfman, Ian Swett
Base URL:
https://chromium.googlesource.com/chromium/src.git@Tidy_up_DLOG_messages_101773586
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: Refactor QuicAckFrame::missing_packets to support a change to a more efficient data structure. No functional change. Added lower_bound and upper_bound methods. Merge internal change: 101778041 R=rch@chromium.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -198 lines) Patch
M net/quic/quic_connection.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M net/quic/quic_connection_logger.cc View 4 chunks +14 lines, -17 lines 1 comment Download
M net/quic/quic_connection_logger_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_connection_test.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M net/quic/quic_framer.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M net/quic/quic_framer_test.cc View 12 chunks +22 lines, -40 lines 0 comments Download
M net/quic/quic_protocol.h View 3 chunks +56 lines, -8 lines 0 comments Download
M net/quic/quic_protocol.cc View 2 chunks +76 lines, -15 lines 0 comments Download
M net/quic/quic_protocol_test.cc View 3 chunks +96 lines, -13 lines 0 comments Download
M net/quic/quic_received_packet_manager.cc View 4 chunks +13 lines, -16 lines 0 comments Download
M net/quic/quic_received_packet_manager_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M net/quic/quic_sent_entropy_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_sent_entropy_manager.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M net/quic/quic_sent_entropy_manager_test.cc View 2 chunks +8 lines, -10 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 20 chunks +21 lines, -38 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1304373010 Patch 1

Dependent Patchsets:

Issue 1333773002 Patch 1

Messages

Total messages: 3 (0 generated)
ramant (doing other things)
5 years, 3 months ago (2015-09-10 03:52:43 UTC) #1
ramant (doing other things)
https://codereview.chromium.org/1330973002/diff/1/net/quic/quic_connection_logger.cc File net/quic/quic_connection_logger.cc (right): https://codereview.chromium.org/1330973002/diff/1/net/quic/quic_connection_logger.cc#newcode560 net/quic/quic_connection_logger.cc:560: const PacketNumberQueue& missing_packets = frame.missing_packets; Hi Ryan, Added lower_bound ...
5 years, 3 months ago (2015-09-10 03:58:26 UTC) #2
Ryan Hamilton
5 years, 3 months ago (2015-09-10 14:30:35 UTC) #3 
On 2015/09/10 03:58:26, ramant wrote:
>
https://codereview.chromium.org/1330973002/diff/1/net/quic/quic_connection_lo...
> File net/quic/quic_connection_logger.cc (right):
> 
>
https://codereview.chromium.org/1330973002/diff/1/net/quic/quic_connection_lo...
> net/quic/quic_connection_logger.cc:560: const PacketNumberQueue&
missing_packets
> = frame.missing_packets;
> Hi Ryan,
>   Added lower_bound method. Could you please take a look at the chromium
> specific files changes?
> 
>   PacketNumberQueue has changed lot more. Will port the changes back to the
> internal code.
> 
> thanks
> raman

LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698