Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: net/quic/quic_received_packet_manager_test.cc

Issue 1330973002: relnote: Refactor QuicAckFrame::missing_packets to support a change to a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Tidy_up_DLOG_messages_101773586
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_received_packet_manager.h" 5 #include "net/quic/quic_received_packet_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <vector> 8 #include <vector>
9 9
10 #include "net/quic/quic_connection_stats.h" 10 #include "net/quic/quic_connection_stats.h"
(...skipping 323 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 EXPECT_EQ(1u, stats_.packets_reordered); 334 EXPECT_EQ(1u, stats_.packets_reordered);
335 } 335 }
336 336
337 TEST_F(QuicReceivedPacketManagerTest, RevivedPacket) { 337 TEST_F(QuicReceivedPacketManagerTest, RevivedPacket) {
338 RecordPacketReceipt(1, 0); 338 RecordPacketReceipt(1, 0);
339 RecordPacketReceipt(3, 0); 339 RecordPacketReceipt(3, 0);
340 RecordPacketRevived(2); 340 RecordPacketRevived(2);
341 341
342 QuicAckFrame ack; 342 QuicAckFrame ack;
343 received_manager_.UpdateReceivedPacketInfo(&ack, QuicTime::Zero()); 343 received_manager_.UpdateReceivedPacketInfo(&ack, QuicTime::Zero());
344 EXPECT_EQ(1u, ack.missing_packets.size()); 344 EXPECT_EQ(1u, ack.missing_packets.NumPackets());
345 EXPECT_EQ(2u, *ack.missing_packets.begin()); 345 EXPECT_EQ(2u, ack.missing_packets.Min());
346 EXPECT_EQ(1u, ack.revived_packets.size()); 346 EXPECT_EQ(1u, ack.revived_packets.size());
347 EXPECT_EQ(2u, *ack.missing_packets.begin()); 347 EXPECT_EQ(2u, *ack.revived_packets.begin());
348 } 348 }
349 349
350 TEST_F(QuicReceivedPacketManagerTest, PacketRevivedThenReceived) { 350 TEST_F(QuicReceivedPacketManagerTest, PacketRevivedThenReceived) {
351 RecordPacketReceipt(1, 0); 351 RecordPacketReceipt(1, 0);
352 RecordPacketReceipt(3, 0); 352 RecordPacketReceipt(3, 0);
353 RecordPacketRevived(2); 353 RecordPacketRevived(2);
354 RecordPacketReceipt(2, 0); 354 RecordPacketReceipt(2, 0);
355 355
356 QuicAckFrame ack; 356 QuicAckFrame ack;
357 received_manager_.UpdateReceivedPacketInfo(&ack, QuicTime::Zero()); 357 received_manager_.UpdateReceivedPacketInfo(&ack, QuicTime::Zero());
358 EXPECT_TRUE(ack.missing_packets.empty()); 358 EXPECT_TRUE(ack.missing_packets.Empty());
359 EXPECT_TRUE(ack.revived_packets.empty()); 359 EXPECT_TRUE(ack.revived_packets.empty());
360 } 360 }
361 361
362 362
363 } // namespace 363 } // namespace
364 } // namespace test 364 } // namespace test
365 } // namespace net 365 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698