Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Side by Side Diff: net/quic/quic_connection_logger_unittest.cc

Issue 1330973002: relnote: Refactor QuicAckFrame::missing_packets to support a change to a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Tidy_up_DLOG_messages_101773586
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_connection_logger.h" 5 #include "net/quic/quic_connection_logger.h"
6 6
7 #include "net/quic/quic_protocol.h" 7 #include "net/quic/quic_protocol.h"
8 #include "net/quic/test_tools/quic_test_utils.h" 8 #include "net/quic/test_tools/quic_test_utils.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
(...skipping 27 matching lines...) Expand all
38 MockQuicSpdySession session_; 38 MockQuicSpdySession session_;
39 QuicConnectionLogger logger_; 39 QuicConnectionLogger logger_;
40 }; 40 };
41 41
42 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSentNotChanged) { 42 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSentNotChanged) {
43 QuicAckFrame frame; 43 QuicAckFrame frame;
44 logger_.OnFrameAddedToPacket(QuicFrame(&frame)); 44 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
45 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_)); 45 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
46 46
47 for (QuicPacketNumber i = 0; i < 256; ++i) { 47 for (QuicPacketNumber i = 0; i < 256; ++i) {
48 frame.missing_packets.insert(i); 48 frame.missing_packets.Add(i);
49 } 49 }
50 logger_.OnFrameAddedToPacket(QuicFrame(&frame)); 50 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
51 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_)); 51 EXPECT_EQ(0u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
52 } 52 }
53 53
54 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSent) { 54 TEST_F(QuicConnectionLoggerTest, TruncatedAcksSent) {
55 QuicAckFrame frame; 55 QuicAckFrame frame;
56 for (QuicPacketNumber i = 0; i < 512; i += 2) { 56 for (QuicPacketNumber i = 0; i < 512; i += 2) {
57 frame.missing_packets.insert(i); 57 frame.missing_packets.Add(i);
58 } 58 }
59 logger_.OnFrameAddedToPacket(QuicFrame(&frame)); 59 logger_.OnFrameAddedToPacket(QuicFrame(&frame));
60 EXPECT_EQ(1u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_)); 60 EXPECT_EQ(1u, QuicConnectionLoggerPeer::num_truncated_acks_sent(logger_));
61 } 61 }
62 62
63 TEST_F(QuicConnectionLoggerTest, ReceivedPacketLossRate) { 63 TEST_F(QuicConnectionLoggerTest, ReceivedPacketLossRate) {
64 QuicConnectionLoggerPeer::set_num_packets_received(logger_, 1); 64 QuicConnectionLoggerPeer::set_num_packets_received(logger_, 1);
65 QuicConnectionLoggerPeer::set_largest_received_packet_number(logger_, 2); 65 QuicConnectionLoggerPeer::set_largest_received_packet_number(logger_, 2);
66 EXPECT_EQ(0.5f, logger_.ReceivedPacketLossRate()); 66 EXPECT_EQ(0.5f, logger_.ReceivedPacketLossRate());
67 } 67 }
68 68
69 } // namespace test 69 } // namespace test
70 } // namespace net 70 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698