Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1333773002: relnote: moves ProcessPacketInterface from quic_dispatcher.h to (Closed)

Created:
5 years, 3 months ago by ramant (doing other things)
Modified:
4 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@Refactor_QuicAckFrame_missing_packets_101778041
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: moves ProcessPacketInterface from quic_dispatcher.h to quic_packet_reader.h, and updates QuiClient to implement this interface. No functional change to internal server. add an new member function in quic client to read multiple packets per call. FIXED=21846229 Merge internal change: 101790938 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -12 lines) Patch
M net/tools/quic/quic_client.h View 5 chunks +18 lines, -1 line 0 comments Download
M net/tools/quic/quic_client.cc View 5 chunks +31 lines, -2 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 2 chunks +1 line, -8 lines 0 comments Download
M net/tools/quic/quic_packet_reader.h View 2 chunks +10 lines, -1 line 0 comments Download
M net/tools/quic/quic_packet_reader.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
ramant (doing other things)
5 years, 3 months ago (2015-09-10 04:33:01 UTC) #1
Ryan Hamilton
lgtm
5 years, 3 months ago (2015-09-10 14:30:44 UTC) #2
ramant (doing other things)
On 2015/09/10 14:30:44, Ryan Hamilton wrote: > lgtm Hi Ryan, This CL doesn't work on ...
5 years, 3 months ago (2015-09-11 23:03:50 UTC) #3
Ryan Hamilton
On 2015/09/11 23:03:50, ramant wrote: > On 2015/09/10 14:30:44, Ryan Hamilton wrote: > > lgtm ...
5 years, 3 months ago (2015-09-18 14:22:43 UTC) #4
ramant (doing other things)
4 years, 11 months ago (2016-01-27 22:57:19 UTC) #6
On 2015/09/18 14:22:43, Ryan Hamilton wrote:
> On 2015/09/11 23:03:50, ramant wrote:
> > On 2015/09/10 14:30:44, Ryan Hamilton wrote:
> > > lgtm
> > 
> > Hi Ryan,
> >   This CL doesn't work on all platforms. Will make it work and try again.
> > Reopened it.
> 
> Doh. Let me know when it's ready.

Really sorry for sitting on this so long. 

Merging this CL in https://codereview.chromium.org/1640343002/

Powered by Google App Engine
This is Rietveld 408576698