Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: net/quic/quic_framer.cc

Issue 1330973002: relnote: Refactor QuicAckFrame::missing_packets to support a change to a (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Tidy_up_DLOG_messages_101773586
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/quic_framer.cc
diff --git a/net/quic/quic_framer.cc b/net/quic/quic_framer.cc
index 7ba2c89440019c965ce6926f39fd97c41897978f..6d99ad4a2d9ecfdd3e5b03c79ce1c6b54fbf92bc 100644
--- a/net/quic/quic_framer.cc
+++ b/net/quic/quic_framer.cc
@@ -984,10 +984,10 @@ uint8 QuicFramer::GetSequenceNumberFlags(
QuicFramer::AckFrameInfo QuicFramer::GetAckFrameInfo(
const QuicAckFrame& frame) {
AckFrameInfo ack_info;
- if (frame.missing_packets.empty()) {
+ if (frame.missing_packets.Empty()) {
return ack_info;
}
- DCHECK_GE(frame.largest_observed, *frame.missing_packets.rbegin());
+ DCHECK_GE(frame.largest_observed, frame.missing_packets.Max());
size_t cur_range_length = 0;
PacketNumberSet::const_iterator iter = frame.missing_packets.begin();
QuicPacketNumber last_missing = *iter;
@@ -1361,9 +1361,8 @@ bool QuicFramer::ProcessAckFrame(QuicDataReader* reader,
set_detailed_error("Unable to read missing packet number range.");
return false;
}
- for (size_t j = 0; j <= range_length; ++j) {
- ack_frame->missing_packets.insert(last_packet_number - j);
- }
+ ack_frame->missing_packets.Add(last_packet_number - range_length,
+ last_packet_number + 1);
// Subtract an extra 1 to ensure ranges are represented efficiently and
// can't overlap by 1 packet number. This allows a missing_delta of 0
// to represent an adjacent nack range.
@@ -2063,7 +2062,7 @@ bool QuicFramer::AppendAckFrameAndTypeByte(
PacketNumberSet::const_iterator iter = frame.revived_packets.begin();
for (int i = 0; i < num_revived_packets; ++i, ++iter) {
- LOG_IF(DFATAL, !ContainsKey(frame.missing_packets, *iter));
+ LOG_IF(DFATAL, !frame.missing_packets.Contains(*iter));
if (!AppendPacketSequenceNumber(largest_observed_length,
*iter, writer)) {
return false;

Powered by Google App Engine
This is Rietveld 408576698