relnote: Refactor QuicAckFrame::missing_packets to support a change to a

net/quic/quic_sent_entropy_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/quic_sent_entropy_manager.h"
 
 #include "base/logging.h"
 #include "net/base/linked_hash_map.h"
 
 using std::make_pair;
@@ skipping 46 matching lines @@
     QuicPacketNumber packet_number) {
   DCHECK_LE(last_cumulative_entropy_.packet_number, packet_number);
   DCHECK_GE(GetLargestPacketWithEntropy(), packet_number);
   // First the entropy for largest_observed packet number should be updated.
   UpdateCumulativeEntropy(packet_number, &last_cumulative_entropy_);
   return last_cumulative_entropy_.entropy;
 }
 
 bool QuicSentEntropyManager::IsValidEntropy(
     QuicPacketNumber largest_observed,
-    const PacketNumberSet& missing_packets,
+    const PacketNumberQueue& missing_packets,
     QuicPacketEntropyHash entropy_hash) {
   DCHECK_GE(largest_observed, last_valid_entropy_.packet_number);
   // Ensure the largest and smallest packet numbers are in range.
   if (largest_observed > GetLargestPacketWithEntropy()) {
     return false;
   }
-  if (!missing_packets.empty() &&
-      *missing_packets.begin() < GetSmallestPacketWithEntropy()) {
+  if (!missing_packets.Empty() &&
+      missing_packets.Min() < GetSmallestPacketWithEntropy()) {
     return false;
   }
   // First the entropy for largest_observed packet number should be updated.
   UpdateCumulativeEntropy(largest_observed, &last_valid_entropy_);
 
   // Now XOR out all the missing entropies.
   QuicPacketEntropyHash expected_entropy_hash = last_valid_entropy_.entropy;
-  for (PacketNumberSet::const_iterator it = missing_packets.begin();
-       it != missing_packets.end(); ++it) {
-    expected_entropy_hash ^= GetPacketEntropy(*it);
+  for (QuicPacketNumber packet : missing_packets) {
+    expected_entropy_hash ^= GetPacketEntropy(packet);
   }
   DLOG_IF(WARNING, entropy_hash != expected_entropy_hash)
       << "Invalid entropy hash: " << static_cast<int>(entropy_hash)
       << " expected entropy hash: " << static_cast<int>(expected_entropy_hash);
   return entropy_hash == expected_entropy_hash;
 }
 
 void QuicSentEntropyManager::ClearEntropyBefore(
     QuicPacketNumber packet_number) {
   // Don't discard entropy before updating the cumulative entropy used to
   // calculate EntropyHash and IsValidEntropy.
   if (last_cumulative_entropy_.packet_number < packet_number) {
     UpdateCumulativeEntropy(packet_number, &last_cumulative_entropy_);
   }
   if (last_valid_entropy_.packet_number < packet_number) {
     UpdateCumulativeEntropy(packet_number, &last_valid_entropy_);
   }
   while (map_offset_ < packet_number) {
     packets_entropy_.pop_front();
     ++map_offset_;
   }
   DVLOG(2) << "Cleared entropy before: " << packet_number;
 }
 
 }  // namespace net