Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1326563002: Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructor This patch introduces |visiblePositionOf()| with |PositionWithAffinity| as replacement of |VisiblePosition| constructor with |PositionWithAffinity| to prepare making |VisiblePosition| constructors private. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201518

Patch Set 1 : 2015-09-01T10:55:04 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -26 lines) Patch
M Source/core/editing/DragCaretController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/SelectionController.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/HitTestResult.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/testing/Internals.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ContextMenuClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSurroundingText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-01 03:01:56 UTC) #2
tkent
lgtm. Maybe it's too late, but I feel the function name should start with a ...
5 years, 3 months ago (2015-09-01 04:01:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1326563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1326563002/1
5 years, 3 months ago (2015-09-01 04:06:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201518
5 years, 3 months ago (2015-09-01 04:15:40 UTC) #6
yosin_UTC9
5 years, 3 months ago (2015-09-01 04:25:32 UTC) #7
Message was sent while issue was closed.
On 2015/09/01 04:01:54, tkent wrote:
> lgtm.
> 
> Maybe it's too late, but I feel the function name should start with a verb
> because it's not a simple accessor.

I'll rename to |computeVisiblePosition()|.

Powered by Google App Engine
This is Rietveld 408576698