Source/core/editing/FrameSelection.cpp - Issue 1326563002: Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 1326563002: Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-09-01T10:55:04 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index 7ec1edf67b601b83597f1cda6c78d0a412076d1c..a2077e0fb317dfb0865febf50ff84f3b6299d0a9 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -1364,7 +1364,7 @@ bool FrameSelection::containsAlgorithm(const LayoutPoint& point)

if (!innerNode || !innerNode->layoutObject())

return false;

- VisiblePosition visiblePos(innerNode->layoutObject()->positionForPoint(result.localPoint()));

+ VisiblePosition visiblePos = visiblePositionOf(innerNode->layoutObject()->positionForPoint(result.localPoint()));

if (visiblePos.isNull())

return false;

« no previous file with comments | « Source/core/editing/DragCaretController.cpp ('k') | Source/core/editing/SelectionController.cpp » ('j') | no next file with comments »