Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo

Source/core/editing/VisiblePosition.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Portions Copyright (c) 2011 Motorola Mobility, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 38 matching lines @@
 
 using namespace HTMLNames;
 
 VisiblePosition::VisiblePosition(const Position& position, TextAffinity affinity)
 {
     // TODO(yosin) We should make |VisiblePosition| private and make this
     // constructor to populate member variables by using |visiblePositionOf()|.
     *this = visiblePositionOf(position, affinity);
 }
 
-VisiblePosition::VisiblePosition(const PositionWithAffinity& positionWithAffinity)
-    : VisiblePosition(positionWithAffinity.position(), positionWithAffinity.affinity())
-{
-}
-
 VisiblePosition VisiblePosition::createWithoutCanonicalization(const PositionWithAffinity& canonicalized)
 {
     VisiblePosition visiblePosition;
     visiblePosition.m_deepPosition = canonicalized.position();
     visiblePosition.m_affinity = canonicalized.affinity();
     return visiblePosition;
 }
 
 // TODO(yosin) We should move |rightVisuallyDistinctCandidate()| with
 // |rightPositionOf()| to "VisibleUnits.cpp".
@@ skipping 358 matching lines @@
     return honorEditingBoundaryAtOrBeforeAlgorithm(pos, anchor);
 }
 
 PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionInComposedTreeWithAffinity& pos, const PositionInComposedTree& anchor)
 {
     return honorEditingBoundaryAtOrBeforeAlgorithm(pos, anchor);
 }
 
 VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition& pos, const Position& anchor)
 {
-    return VisiblePosition(honorEditingBoundaryAtOrBeforeOf(pos.toPositionWithAffinity(), anchor));
+    return visiblePositionOf(honorEditingBoundaryAtOrBeforeOf(pos.toPositionWithAffinity(), anchor));
 }
 
 VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition& pos, const Position& anchor)
 {
     if (pos.isNull())
         return pos;
 
     ContainerNode* highestRoot = highestEditableRoot(anchor);
 
     // Return empty position if pos is not somewhere inside the editable region containing this position
@@ skipping 124 matching lines @@
     if (inSameLine(PositionWithAffinityTemplate<Strategy>(deepPosition), PositionWithAffinityTemplate<Strategy>(deepPosition, TextAffinity::Upstream)))
         return PositionWithAffinityTemplate<Strategy>(deepPosition);
     return PositionWithAffinityTemplate<Strategy>(deepPosition, TextAffinity::Upstream);
 }
 
 VisiblePosition visiblePositionOf(const Position& position, TextAffinity affinity)
 {
     return VisiblePosition::createWithoutCanonicalization(visiblePositionOfAlgorithm<EditingStrategy>(position, affinity));
 }
 
+VisiblePosition visiblePositionOf(const PositionWithAffinity& positionWithAffinity)
+{
+    return visiblePositionOf(positionWithAffinity.position(), positionWithAffinity.affinity());
+}
+
 VisiblePosition visiblePositionOf(const PositionInComposedTree& position, TextAffinity affinity)
 {
     PositionInComposedTreeWithAffinity canonicalized = visiblePositionOfAlgorithm<EditingInComposedTreeStrategy>(position, affinity);
     return VisiblePosition::createWithoutCanonicalization(PositionWithAffinity(toPositionInDOMTree(canonicalized.position()), canonicalized.affinity()));
 }
 
 UChar32 characterAfter(const VisiblePosition& visiblePosition)
 {
     // We canonicalize to the first of two equivalent candidates, but the second
     // of the two candidates is the one that will be inside the text node
@@ skipping 90 matching lines @@
     else
         fprintf(stderr, "Cannot showTree for (nil) VisiblePosition.\n");
 }
 
 void showTree(const blink::VisiblePosition& vpos)
 {
     vpos.showTreeForThis();
 }
 
 #endif