Source/core/layout/HitTestResult.cpp - Issue 1326563002: Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/HitTestResult.cpp

Issue 1326563002: Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-09-01T10:55:04 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/layout/HitTestResult.cpp

diff --git a/Source/core/layout/HitTestResult.cpp b/Source/core/layout/HitTestResult.cpp

index 2eb6c81e8298ac0347d7b9f94f9c3d85f30d076f..efbab2fa6ee4f3127092be8f612ddf69d06c85c3 100644

--- a/Source/core/layout/HitTestResult.cpp

+++ b/Source/core/layout/HitTestResult.cpp

@@ -386,11 +386,13 @@ bool HitTestResult::isLiveLink() const

return m_innerURLElement && m_innerURLElement->isLiveLink();

}

+// TODO(yosin) We should move |HitTestResult::isMisspelled()| to

+// "SelectionController.cpp" as static function.

bool HitTestResult::isMisspelled() const

{

if (!innerNode() || !innerNode()->layoutObject())

return false;

- VisiblePosition pos(innerNode()->layoutObject()->positionForPoint(localPoint()));

+ VisiblePosition pos = visiblePositionOf(innerNode()->layoutObject()->positionForPoint(localPoint()));

if (pos.isNull())

return false;

return m_innerNode->document().markers().markersInRange(

« no previous file with comments | « Source/core/frame/LocalFrame.cpp ('k') | Source/core/testing/Internals.cpp » ('j') | no next file with comments »