Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo

Source/core/editing/VisiblePosition.h

 /*
  * Copyright (C) 2004, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 58 matching lines @@
 // otherwise it will be converted to DOWNSTREAM.
 class CORE_EXPORT VisiblePosition final {
     DISALLOW_ALLOCATION();
 public:
     VisiblePosition() : m_affinity(VP_DEFAULT_AFFINITY) { }
 
     // TODO(yosin) We should use |visiblePositionOf()| instead of constructor,
     // and make constructors to have private accessibility, since constructors
     // aren't simple, e.g. they update layout tree.
     explicit VisiblePosition(const Position&, TextAffinity = VP_DEFAULT_AFFINITY);
-    explicit VisiblePosition(const PositionWithAffinity&);
 
     // Node: Other than |visiblePositionOf()|, we should not use
     // |createWithoutCanonicalization()|.
     static VisiblePosition createWithoutCanonicalization(const PositionWithAffinity& canonicalized);
 
     // Intentionally delete |operator==()| and |operator!=()| for reducing
     // compilation error message.
     // TODO(yosin) We'll have |equals()| when we have use cases of checking
     // equality of both position and affinity.
     bool operator==(const VisiblePosition&) const = delete;
@@ skipping 49 matching lines @@
 
 // TODO(yosin) We should move |honorEditingBoundaryAtOr{Before,After} to
 // "VisibleUnits.cpp" as static function.
 // next() and previous() will increment/decrement by a character cluster.
 VisiblePosition honorEditingBoundaryAtOrBefore(const VisiblePosition&, const Position& anchor);
 PositionWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionWithAffinity&, const Position& anchor);
 PositionInComposedTreeWithAffinity honorEditingBoundaryAtOrBeforeOf(const PositionInComposedTreeWithAffinity&, const PositionInComposedTree& anchor);
 VisiblePosition honorEditingBoundaryAtOrAfter(const VisiblePosition&, const Position& anchor);
 
 CORE_EXPORT VisiblePosition visiblePositionOf(const Position&, TextAffinity = VP_DEFAULT_AFFINITY);
+CORE_EXPORT VisiblePosition visiblePositionOf(const PositionWithAffinity&);
 CORE_EXPORT VisiblePosition visiblePositionOf(const PositionInComposedTree&, TextAffinity = VP_DEFAULT_AFFINITY);
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showTree(const blink::VisiblePosition*);
 void showTree(const blink::VisiblePosition&);
 #endif
 
 #endif // VisiblePosition_h