Source/core/frame/LocalFrame.cpp - Issue 1326563002: Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 1326563002: Introduce visiblePositionOf() with PositionWithAffinity as replacement of VisiblePosition constructo (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-09-01T10:55:04 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/LocalFrame.cpp

diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp

index 64a1032dd52822c215722a3bb8ee72a01a7e3d1f..44ce13e81e0019c0d22bc907f807098d923b2269 100644

--- a/Source/core/frame/LocalFrame.cpp

+++ b/Source/core/frame/LocalFrame.cpp

@@ -706,7 +706,7 @@ EphemeralRange LocalFrame::rangeForPoint(const IntPoint& framePoint)

if (positionWithAffinity.isNull())

return EphemeralRange();

- VisiblePosition position(positionWithAffinity);

+ VisiblePosition position = visiblePositionOf(positionWithAffinity);

VisiblePosition previous = previousPositionOf(position);

if (previous.isNotNull()) {

const EphemeralRange previousCharacterRange = makeRange(previous, position);

« no previous file with comments | « Source/core/editing/VisibleUnits.cpp ('k') | Source/core/layout/HitTestResult.cpp » ('j') | no next file with comments »