Clean up remaining users of SkPMFloat

Clean up remaining users of SkPMFloat

This switches over SkXfermodes_opts.h and SkColorMatrixFilter to use Sk4f,
and converts the SkPMFloat benches to Sk4f benches.

No pixels should change here, and no code beyond the Sk4f_ benches should change speed.
The benches are faster than the old versions.

BUG=skia:4117
Committed: https://skia.googlesource.com/skia/+/dde03ff89f58d7df9b9e37ca06c2ce8ea67ec7a2

[mtklein, 2015-08-31 21:40:26]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 21:40:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324743002/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324743002/70001

[commit-bot: I haz the power, 2015-08-31 21:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 21:41:36]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[mtklein, 2015-08-31 21:46:15]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 21:46:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324743002/110001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324743002/110001

[commit-bot: I haz the power, 2015-08-31 21:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 21:50:08]

Dry run: Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[mtklein, 2015-08-31 21:50:15]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 21:50:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324743002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324743002/130001

[commit-bot: I haz the power, 2015-08-31 21:55:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-31 21:55:04]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2015-08-31 22:05:56]

mtklein@chromium.org changed reviewers:
+ reed@google.com
- mtklein@google.com

[reed1, 2015-08-31 22:09:37]

https://codereview.chromium.org/1324743002/diff/130001/src/effects/SkColorMat...
File src/effects/SkColorMatrixFilter.cpp (right):

https://codereview.chromium.org/1324743002/diff/130001/src/effects/SkColorMat...
src/effects/SkColorMatrixFilter.cpp:243: static_assert(SK_A32_SHIFT == 24, "");
why do we need this assert, if we're using the #defines everywhere we use the
kth<> operator?

[mtklein, 2015-08-31 22:13:12]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-08-31 22:13:13]

https://codereview.chromium.org/1324743002/diff/130001/src/effects/SkColorMat...
File src/effects/SkColorMatrixFilter.cpp (right):

https://codereview.chromium.org/1324743002/diff/130001/src/effects/SkColorMat...
src/effects/SkColorMatrixFilter.cpp:243: static_assert(SK_A32_SHIFT == 24, "");
On 2015/08/31 22:09:37, reed1 wrote:
> why do we need this assert, if we're using the #defines everywhere we use the
> kth<> operator?

scale is fine, yeah, but we also need Sk4f(scale,scale,scale,1) to put the 1 in
the alpha slot.

[reed1, 2015-08-31 22:15:08]

lgtm

https://codereview.chromium.org/1324743002/diff/130001/src/effects/SkColorMat...
File src/effects/SkColorMatrixFilter.cpp (right):

https://codereview.chromium.org/1324743002/diff/130001/src/effects/SkColorMat...
src/effects/SkColorMatrixFilter.cpp:243: static_assert(SK_A32_SHIFT == 24, "");
On 2015/08/31 22:13:13, mtklein wrote:
> On 2015/08/31 22:09:37, reed1 wrote:
> > why do we need this assert, if we're using the #defines everywhere we use
the
> > kth<> operator?
> 
> scale is fine, yeah, but we also need Sk4f(scale,scale,scale,1) to put the 1
in
> the alpha slot.

Ah, ok.

nit: move the assert after the kth<>, right above the scale, and have the string
be something like "assume alpha is the 4th parameter"

[mtklein, 2015-08-31 22:18:10]

https://codereview.chromium.org/1324743002/diff/130001/src/effects/SkColorMat...
File src/effects/SkColorMatrixFilter.cpp (right):

https://codereview.chromium.org/1324743002/diff/130001/src/effects/SkColorMat...
src/effects/SkColorMatrixFilter.cpp:243: static_assert(SK_A32_SHIFT == 24, "");
On 2015/08/31 22:15:08, reed1 wrote:
> On 2015/08/31 22:13:13, mtklein wrote:
> > On 2015/08/31 22:09:37, reed1 wrote:
> > > why do we need this assert, if we're using the #defines everywhere we use
> the
> > > kth<> operator?
> > 
> > scale is fine, yeah, but we also need Sk4f(scale,scale,scale,1) to put the 1
> in
> > the alpha slot.
> 
> Ah, ok.
> 
> nit: move the assert after the kth<>, right above the scale, and have the
string
> be something like "assume alpha is the 4th parameter"

Have a look at PS 9?

[mtklein, 2015-08-31 22:20:19]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-08-31 22:20:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324743002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324743002/150001

[reed1, 2015-08-31 22:22:39]

nice, lgtm

[mtklein, 2015-08-31 22:23:57]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2015-08-31 22:23:59]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-08-31 22:24:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1324743002/150001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1324743002/150001

[commit-bot: I haz the power, 2015-08-31 22:26:11]

Committed patchset #9 (id:150001) as
https://skia.googlesource.com/skia/+/dde03ff89f58d7df9b9e37ca06c2ce8ea67ec7a2