Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1319893002: Make classes and structures in core/paint fast-allocated. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, jfernandez, svillar, dshwang, Manuel Rego, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in core/paint fast-allocated. Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201366

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -1 line) Patch
M Source/core/paint/BlockFlowPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/BlockPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/BoxClipper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/BoxPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/ClipScope.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/paint/CompositingRecorder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayer.h View 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerClipper.h View 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerFilterInfo.h View 2 chunks +3 lines, -0 lines 2 comments Download
M Source/core/paint/DeprecatedPaintLayerFragment.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerPaintingInfo.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerReflectionInfo.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerScrollableArea.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerStackingNode.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/DeprecatedPaintLayerStackingNodeIterator.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/DetailsMarkerPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/EllipsisBoxPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/EmbeddedObjectPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/FieldsetPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/FileUploadControlPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/FilterPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/FloatClipRecorder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M Source/core/paint/FrameSetPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/GridPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/HTMLCanvasPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/ImagePainter.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/InlineFlowBoxPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/InlinePainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/InlineTextBoxPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/LayerClipRecorder.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/paint/LayoutObjectDrawingRecorder.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/LineBoxListPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/ListItemPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/ListMarkerPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/MediaControlsPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/MultiColumnSetPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/NinePieceImageGrid.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/ObjectPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/PaintInfo.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/PartPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/ReplacedPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/ReplicaPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/RootInlineBoxPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/RoundedInnerRectClipper.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/SVGClipPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/SVGContainerPainter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/paint/SVGFilterPainter.h View 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/paint/SVGForeignObjectPainter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/paint/SVGImagePainter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/paint/SVGInlineFlowBoxPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/SVGMaskPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/SVGRootInlineBoxPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/SVGRootPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/SVGShapePainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/SVGTextPainter.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/paint/ScopeRecorder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/TableCellPainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/TablePainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/TableRowPainter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/paint/TableSectionPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/TextPainter.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/ThemePainter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/Transform3DRecorder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/TransformRecorder.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/paint/VideoPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/paint/ViewPainter.h View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-08-27 07:51:27 UTC) #2
haraken
LGTM https://codereview.chromium.org/1319893002/diff/20001/Source/core/paint/DeprecatedPaintLayerFilterInfo.h File Source/core/paint/DeprecatedPaintLayerFilterInfo.h (right): https://codereview.chromium.org/1319893002/diff/20001/Source/core/paint/DeprecatedPaintLayerFilterInfo.h#newcode52 Source/core/paint/DeprecatedPaintLayerFilterInfo.h:52: WTF_MAKE_FAST_ALLOCATED(DeprecatedPaintLayerFilterInfo); Just to confirm: You don't want to ...
5 years, 3 months ago (2015-08-27 09:02:49 UTC) #3
tasak
Thank you for review. https://codereview.chromium.org/1319893002/diff/20001/Source/core/paint/DeprecatedPaintLayerFilterInfo.h File Source/core/paint/DeprecatedPaintLayerFilterInfo.h (right): https://codereview.chromium.org/1319893002/diff/20001/Source/core/paint/DeprecatedPaintLayerFilterInfo.h#newcode52 Source/core/paint/DeprecatedPaintLayerFilterInfo.h:52: WTF_MAKE_FAST_ALLOCATED(DeprecatedPaintLayerFilterInfo); On 2015/08/27 09:02:49, haraken ...
5 years, 3 months ago (2015-08-28 03:58:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1319893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1319893002/20001
5 years, 3 months ago (2015-08-28 03:58:53 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 04:04:16 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201366

Powered by Google App Engine
This is Rietveld 408576698