Plumb requireInteraction to PlatformNotificationData & database

Plumb requireInteraction to PlatformNotificationData & database

Part of a 3-sided patch:
1. https://codereview.chromium.org/1309273007
2. this patch
3. https://codereview.chromium.org/1313013006

BUG=507751
Committed: https://crrev.com/046341a48e12b50d509ad69e2fa3a7e9c16fd941
Cr-Commit-Position: refs/heads/master@{#346650}

[johnme, 2015-08-26 18:33:11]

johnme@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2015-08-27 14:20:46]

lgtm

https://codereview.chromium.org/1313363006/diff/1/content/public/common/platf...
File content/public/common/platform_notification_data.h (right):

https://codereview.chromium.org/1313363006/diff/1/content/public/common/platf...
content/public/common/platform_notification_data.h:75: // Whether the
notification should remain onscreen indefinitely, rather than
I'd prefer this description to be a little bit higher level. Implementation of
the require_interaction flag is left up to the platform notification center
(i.e. message_center and Android).

[johnme, 2015-08-28 14:16:03]

I added the code to make requireInteraction take effect to
platform_notification_service_impl.cc. Please re-review, thanks :)

[Peter Beverloo, 2015-08-28 14:17:54]

https://codereview.chromium.org/1313363006/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/platform_notification_service_impl.cc (right):

https://codereview.chromium.org/1313363006/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/platform_notification_service_impl.cc:349: if
(notification_data.require_interaction)
We can't do this.

The feature is still marked as experimental and thus not enabled by default.
This means that the default behavior in Chromium builds (and soon Canary/Dev)
will change to auto-minimize, with no means for developers to change this
behavior.

I'm not sure what the right course of action here is. Check for the
experimental-web-platform-features command line flag?

[johnme, 2015-08-28 14:35:50]

Ah, I thought we were waiting for intent to implement and ship to land this, but
I guess we can just do intent to implement for now. Added a flag check
accordingly.

[johnme, 2015-08-28 15:57:30]

johnme@chromium.org changed reviewers:
+ nasko@chromium.org

[johnme, 2015-08-28 15:57:30]

nasko@chromium.org: Please review changes in
content/common/platform_notification_messages.h and
content/public/common/platform_notification_data.h. Thanks!

[johnme, 2015-08-28 15:57:59]

johnme@chromium.org changed reviewers:
- nasko@chromium.org

[johnme, 2015-08-28 15:59:12]

johnme@chromium.org changed reviewers:
+ avi@chromium.org, palmer@chromium.org

[johnme, 2015-08-28 15:59:12]

palmer@chromium.org: Please review
content/common/platform_notification_messages.h

avi@chromium.org: Please review
content/public/common/platform_notification_data.h

Thanks!

[Avi (use Gerrit), 2015-08-28 16:05:01]

lgtm

[palmer, 2015-08-28 20:27:45]

LGTM

[johnme, 2015-09-01 13:25:32]

The CQ bit was checked by johnme@chromium.org

[johnme, 2015-09-01 13:25:33]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1313363006/#ps60001
(title: "Fix includes")

[commit-bot: I haz the power, 2015-09-01 13:25:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1313363006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1313363006/60001

[commit-bot: I haz the power, 2015-09-01 14:40:13]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-01 14:40:59]

Patchset 4 (id:??) landed as
https://crrev.com/046341a48e12b50d509ad69e2fa3a7e9c16fd941
Cr-Commit-Position: refs/heads/master@{#346650}