content/child/notifications/notification_data_conversions.cc - Issue 1313363006: Plumb requireInteraction to PlatformNotificationData & database

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/notifications/notification_data_conversions.cc

Issue 1313363006: Plumb requireInteraction to PlatformNotificationData & database (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@constructor

Patch Set: Fix includes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/notifications/notification_database_data_unittest.cc ('k') | content/child/notifications/notification_data_conversions_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/notifications/notification_data_conversions.cc

diff --git a/content/child/notifications/notification_data_conversions.cc b/content/child/notifications/notification_data_conversions.cc

index 815b11242cca5cceab2d1505e57c1ace1457dfc4..9f05f0d0b61f3719bd8fb0cd3769c95477c6bbf0 100644

--- a/content/child/notifications/notification_data_conversions.cc

+++ b/content/child/notifications/notification_data_conversions.cc

@@ -41,6 +41,7 @@ PlatformNotificationData ToPlatformNotificationData(

platform_data.vibration_pattern.assign(web_data.vibrate.begin(),

web_data.vibrate.end());

platform_data.silent = web_data.silent;

+ platform_data.require_interaction = web_data.requireInteraction;

platform_data.data.assign(web_data.data.begin(), web_data.data.end());

platform_data.actions.resize(web_data.actions.size());

for (size_t i = 0; i < web_data.actions.size(); ++i) {

@@ -75,6 +76,7 @@ WebNotificationData ToWebNotificationData(

web_data.icon = blink::WebURL(platform_data.icon);

web_data.vibrate = platform_data.vibration_pattern;

web_data.silent = platform_data.silent;

+ web_data.requireInteraction = platform_data.require_interaction;

web_data.data = platform_data.data;

blink::WebVector<blink::WebNotificationAction> resized(

platform_data.actions.size());