Ship Notifications requireInteraction by default (chromium side)

Ship Notifications requireInteraction by default (chromium side)

Intent to Ship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/Yr_sEG3cnWw/97sk8JXCAwAJ

This is a 2-sided patch:
1. https://codereview.chromium.org/1319783006
2. this patch

BUG=507751
Committed: https://crrev.com/b811b7168de721d4463e977bf72bb5a48e7d4b2d
Cr-Commit-Position: refs/heads/master@{#348871}

[johnme, 2015-08-28 18:10:56]

johnme@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2015-09-01 11:26:08]

I'd like to see at least one browser test prior to shipping this feature. Can
you add tests to verify that the never_timeout flag is set or not depending on
the requireInteraction parameter?

[johnme, 2015-09-01 13:25:02]

On 2015/09/01 11:26:08, Peter Beverloo wrote:
> I'd like to see at least one browser test prior to shipping this feature. Can
> you add tests to verify that the never_timeout flag is set or not depending on
> the requireInteraction parameter?

Done.

[Peter Beverloo, 2015-09-08 09:46:03]

lgtm % comment. Thanks for the test!

Please link to the Intent to Ship in the CL's description.

https://codereview.chromium.org/1320173002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/platform_notification_service_browsertest.cc
(right):

https://codereview.chromium.org/1320173002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/platform_notification_service_browsertest.cc:231:
EXPECT_EQ("", base::UTF16ToUTF8(default_notification.title()));
Could you give this a title, even if it's just a single character? I'd like to
nuke support zero-length titles if we can, it's a required field for a reason.

[johnme, 2015-09-14 16:14:58]

Addressed review comments. Thanks!

> Please link to the Intent to Ship in the CL's description.

Done

https://codereview.chromium.org/1320173002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/platform_notification_service_browsertest.cc
(right):

https://codereview.chromium.org/1320173002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/platform_notification_service_browsertest.cc:231:
EXPECT_EQ("", base::UTF16ToUTF8(default_notification.title()));
On 2015/09/08 09:46:02, Peter Beverloo wrote:
> Could you give this a title, even if it's just a single character? I'd like to
> nuke support zero-length titles if we can, it's a required field for a reason.

Done.

[johnme, 2015-09-15 10:20:20]

The CQ bit was checked by johnme@chromium.org

[johnme, 2015-09-15 10:20:20]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/1320173002/#ps40001
(title: "Always set title in browsertest")

[commit-bot: I haz the power, 2015-09-15 10:20:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1320173002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1320173002/40001

[commit-bot: I haz the power, 2015-09-15 11:34:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-15 11:35:24]

Patchset 3 (id:??) landed as
https://crrev.com/b811b7168de721d4463e977bf72bb5a48e7d4b2d
Cr-Commit-Position: refs/heads/master@{#348871}

[commit-bot: I haz the power, 2015-09-23 12:44:12]

Patchset 3 (id:??) landed as
https://crrev.com/b811b7168de721d4463e977bf72bb5a48e7d4b2d
Cr-Commit-Position: refs/heads/master@{#348871}