Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1313013006: Enable test for notifications requireInteraction (Closed)

Created:
5 years, 3 months ago by johnme
Modified:
5 years, 3 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@requireinteraction1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Enable test for notifications requireInteraction Part of a 3-sided patch: 1. https://codereview.chromium.org/1309273007 2. https://codereview.chromium.org/1313363006 3. this patch BUG=507751 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201643

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
johnme
5 years, 3 months ago (2015-08-28 15:55:43 UTC) #2
Peter Beverloo
lgtm
5 years, 3 months ago (2015-09-01 11:27:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1313013006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1313013006/1
5 years, 3 months ago (2015-09-02 13:09:58 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 14:04:04 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201643

Powered by Google App Engine
This is Rietveld 408576698