Plumb requireInteraction to PlatformNotificationData & database

chrome/browser/notifications/platform_notification_service_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 
 #include "base/metrics/histogram_macros.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
@@ skipping 325 matching lines @@
       DisplayNameForContextMessage(profile, origin));
   notification.set_vibration_pattern(notification_data.vibration_pattern);
   notification.set_silent(notification_data.silent);
 
   std::vector<message_center::ButtonInfo> buttons;
   for (const auto& action : notification_data.actions)
     buttons.push_back(message_center::ButtonInfo(action.title));
 
   notification.set_buttons(buttons);
 
-  // Web Notifications do not timeout.
-  notification.set_never_timeout(true);
+  // On desktop, notifications with require_interaction==true stay on-screen
+  // rather than minimizing to the notification center after a timeout.
+  // On mobile, this is ignored (notifications are minimized at all times).
+  if (notification_data.require_interaction)

[Peter Beverloo, 2015/08/28 14:17:54]

We can't do this.

The feature is still marked as experimental and thus not enabled by default.
This means that the default behavior in Chromium builds (and soon Canary/Dev)
will change to auto-minimize, with no means for developers to change this
behavior.

I'm not sure what the right course of action here is. Check for the
experimental-web-platform-features command line flag?

+    notification.set_never_timeout(true);
 
   return notification;
 }
 
 NotificationUIManager*
 PlatformNotificationServiceImpl::GetNotificationUIManager() const {
   if (notification_ui_manager_for_tests_)
     return notification_ui_manager_for_tests_;
 
   return g_browser_process->notification_ui_manager();
@@ skipping 14 matching lines @@
         extensions::ExtensionRegistry::Get(profile)->GetExtensionById(
             origin.host(), extensions::ExtensionRegistry::EVERYTHING);
     DCHECK(extension);
 
     return base::UTF8ToUTF16(extension->name());
   }
 #endif
 
   return base::string16();
 }