Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1309273007: Add requireInteraction to Notification & NotificationOptions (Closed)

Created:
5 years, 3 months ago by johnme
Modified:
5 years, 3 months ago
Reviewers:
Peter Beverloo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, dglazkov+blink, kinuko+serviceworker, horo+watch_chromium.org, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@constructor
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add to NotificationDataTest.cpp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M LayoutTests/http/tests/notifications/notification-properties.html View 3 chunks +3 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/notifications/serviceworker-notificationclick-event-reflection.html View 1 2 chunks +5 lines, -0 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/notifications/Notification.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/notifications/Notification.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/notifications/Notification.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/notifications/NotificationData.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/notifications/NotificationDataTest.cpp View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/modules/notifications/NotificationOptions.idl View 1 chunk +1 line, -0 lines 0 comments Download
M public/platform/modules/notifications/WebNotificationData.h View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 1321643002 Patch 20001

Dependent Patchsets:

Issue 1313013006 Patch 1

Messages

Total messages: 13 (4 generated)
johnme
5 years, 3 months ago (2015-08-26 16:13:37 UTC) #2
Peter Beverloo
https://codereview.chromium.org/1309273007/diff/1/Source/modules/notifications/NotificationData.cpp File Source/modules/notifications/NotificationData.cpp (right): https://codereview.chromium.org/1309273007/diff/1/Source/modules/notifications/NotificationData.cpp#newcode60 Source/modules/notifications/NotificationData.cpp:60: webData.requireInteraction = options.requireInteraction(); test?
5 years, 3 months ago (2015-08-27 14:18:54 UTC) #3
johnme
https://codereview.chromium.org/1309273007/diff/1/Source/modules/notifications/NotificationData.cpp File Source/modules/notifications/NotificationData.cpp (right): https://codereview.chromium.org/1309273007/diff/1/Source/modules/notifications/NotificationData.cpp#newcode60 Source/modules/notifications/NotificationData.cpp:60: webData.requireInteraction = options.requireInteraction(); On 2015/08/27 14:18:54, Peter Beverloo wrote: ...
5 years, 3 months ago (2015-08-27 14:47:09 UTC) #4
Peter Beverloo
lgtm, but please don't land until (1) the Intent has been sent, and (2) the ...
5 years, 3 months ago (2015-08-27 14:59:27 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309273007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309273007/20001
5 years, 3 months ago (2015-08-28 16:00:42 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-28 17:35:19 UTC) #9
johnme
On 2015/08/27 14:59:27, Peter Beverloo wrote: > lgtm, but please don't land until (1) the ...
5 years, 3 months ago (2015-08-28 18:06:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309273007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309273007/20001
5 years, 3 months ago (2015-08-28 18:06:50 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 18:11:42 UTC) #13
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201416

Powered by Google App Engine
This is Rietveld 408576698