[BackgroundSync] Use appopriate type parameters for WebCallbacks (2/4)

[BackgroundSync] Use appopriate type parameters for WebCallbacks (2/4)

This series of CLs fixes WebCallback parameter types used in BackgroundSync.

 - WebSyncRegistration* (ownership transferred)
  => PassOwnPtr<WebServiceWorkerResponse>
 - bool* (ownership transferred)
  => bool
 - WebVector<WebSyncRegstration*>* (ownership transferred)
  => const WebVector<WebSyncRegistration*>&
 - WebPermissionStatus* (ownership transferred)
  => WebPermissionStatus
 - WebSyncError* (ownership transferred)
  => const WebSyncError&

1/4: https://codereview.chromium.org/1309143002/
2/4: https://codereview.chromium.org/1311053002/
3/4: https://codereview.chromium.org/1308273002/
4/4: https://codereview.chromium.org/1308283002/

BUG=493531
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201312

[yhirano, 2015-08-24 08:46:51]

yhirano@chromium.org changed reviewers:
+ jkarlin@chromium.org

[jkarlin, 2015-08-24 11:50:10]

lgtm w/ question

https://codereview.chromium.org/1311053002/diff/1/Source/modules/background_s...
File Source/modules/background_sync/SyncCallbacks.cpp (right):

https://codereview.chromium.org/1311053002/diff/1/Source/modules/background_s...
Source/modules/background_sync/SyncCallbacks.cpp:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
Why this change?

[yhirano, 2015-08-24 14:07:39]

https://codereview.chromium.org/1311053002/diff/1/Source/modules/background_s...
File Source/modules/background_sync/SyncCallbacks.cpp (right):

https://codereview.chromium.org/1311053002/diff/1/Source/modules/background_s...
Source/modules/background_sync/SyncCallbacks.cpp:1: // Copyright 2014 The
Chromium Authors. All rights reserved.
On 2015/08/24 11:50:09, jkarlin wrote:
> Why this change?

Sorry, this was not intended. Fixed.

[jkarlin, 2015-08-26 13:21:16]

https://codereview.chromium.org/1311053002/diff/20001/public/platform/modules...
File public/platform/modules/background_sync/WebSyncProvider.h (right):

https://codereview.chromium.org/1311053002/diff/20001/public/platform/modules...
public/platform/modules/background_sync/WebSyncProvider.h:121:
callbacks->onError(new WebSyncError(WebSyncError::ErrorTypeAbort, "Function not
implemented."));
Won't this fail because of the WebSyncError*?

[yhirano, 2015-08-27 02:21:52]

https://codereview.chromium.org/1311053002/diff/20001/public/platform/modules...
File public/platform/modules/background_sync/WebSyncProvider.h (right):

https://codereview.chromium.org/1311053002/diff/20001/public/platform/modules...
public/platform/modules/background_sync/WebSyncProvider.h:121:
callbacks->onError(new WebSyncError(WebSyncError::ErrorTypeAbort, "Function not
implemented."));
On 2015/08/26 13:21:16, jkarlin wrote:
> Won't this fail because of the WebSyncError*?

Technically it's OK because onError(WebSyncError*) is defined at L44. From code
simplicity your suggestion is reasonable and so I fixed it.

[yhirano, 2015-08-27 02:23:59]

https://codereview.chromium.org/1311053002/diff/20001/public/platform/modules...
File public/platform/modules/background_sync/WebSyncProvider.h (right):

https://codereview.chromium.org/1311053002/diff/20001/public/platform/modules...
public/platform/modules/background_sync/WebSyncProvider.h:121:
callbacks->onError(new WebSyncError(WebSyncError::ErrorTypeAbort, "Function not
implemented."));
On 2015/08/27 02:21:52, yhirano wrote:
> On 2015/08/26 13:21:16, jkarlin wrote:
> > Won't this fail because of the WebSyncError*?
> 
> Technically it's OK because onError(WebSyncError*) is defined at L44. From
code
> simplicity your suggestion is reasonable and so I fixed it.

"From code simplicity viewpoint", I mean.

[yhirano, 2015-08-27 12:00:10]

The CQ bit was checked by yhirano@chromium.org

[yhirano, 2015-08-27 12:00:10]

The patchset sent to the CQ was uploaded after l-g-t-m from jkarlin@chromium.org
Link to the patchset: https://codereview.chromium.org/1311053002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-08-27 12:00:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1311053002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1311053002/40001

[commit-bot: I haz the power, 2015-08-27 13:28:31]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201312