Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1309143002: [BackgroundSync] Use appopriate type parameters for WebCallbacks (1/4) (Closed)

Created:
5 years, 4 months ago by yhirano
Modified:
5 years, 3 months ago
Reviewers:
jkarlin
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[BackgroundSync] Use appopriate type parameters for WebCallbacks (1/4) This series of CLs fixes WebCallback parameter types used in BackgroundSync. - WebSyncRegistration* (ownership transferred) => PassOwnPtr<WebServiceWorkerResponse> - bool* (ownership transferred) => bool - WebVector<WebSyncRegstration*>* (ownership transferred) => const WebVector<WebSyncRegistration*>& - WebPermissionStatus* (ownership transferred) => WebPermissionStatus - WebSyncError* (ownership transferred) => const WebSyncError& 1/4: https://codereview.chromium.org/1309143002/ 2/4: https://codereview.chromium.org/1311053002/ 3/4: https://codereview.chromium.org/1308273002/ 4/4: https://codereview.chromium.org/1308283002/ BUG=493531 Committed: https://crrev.com/bd6e0120cff73aaea3c1356502cbdb23f4afaf3e Cr-Commit-Position: refs/heads/master@{#345796}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -35 lines) Patch
M content/child/background_sync/background_sync_provider_thread_proxy.cc View 1 7 chunks +48 lines, -35 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yhirano
5 years, 4 months ago (2015-08-24 08:46:39 UTC) #2
jkarlin
lgtm
5 years, 4 months ago (2015-08-24 11:32:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1309143002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1309143002/20001
5 years, 3 months ago (2015-08-27 02:24:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-08-27 04:40:37 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 04:41:18 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd6e0120cff73aaea3c1356502cbdb23f4afaf3e
Cr-Commit-Position: refs/heads/master@{#345796}

Powered by Google App Engine
This is Rietveld 408576698