Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1308283002: [BackgroundSync] Use appopriate type parameters for WebCallbacks (4/4) (Closed)

Created:
5 years, 4 months ago by yhirano
Modified:
5 years, 3 months ago
Reviewers:
jkarlin
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[BackgroundSync] Use appopriate type parameters for WebCallbacks (4/4) This series of CLs fixes WebCallback parameter types used in BackgroundSync. - WebSyncRegistration* (ownership transferred) => PassOwnPtr<WebServiceWorkerResponse> - bool* (ownership transferred) => bool - WebVector<WebSyncRegstration*>* (ownership transferred) => const WebVector<WebSyncRegistration*>& - WebPermissionStatus* (ownership transferred) => WebPermissionStatus - WebSyncError* (ownership transferred) => const WebSyncError& 1/4: https://codereview.chromium.org/1309143002/ 2/4: https://codereview.chromium.org/1311053002/ 3/4: https://codereview.chromium.org/1308273002/ 4/4: https://codereview.chromium.org/1308283002/ BUG=493531 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201330

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -67 lines) Patch
M public/platform/modules/background_sync/WebSyncProvider.h View 1 1 chunk +0 lines, -67 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (2 generated)
yhirano
5 years, 4 months ago (2015-08-24 08:47:21 UTC) #2
jkarlin
https://codereview.chromium.org/1308283002/diff/1/public/platform/modules/background_sync/WebSyncProvider.h File public/platform/modules/background_sync/WebSyncProvider.h (right): https://codereview.chromium.org/1308283002/diff/1/public/platform/modules/background_sync/WebSyncProvider.h#newcode54 public/platform/modules/background_sync/WebSyncProvider.h:54: callbacks->onError(WebSyncError(WebSyncError::ErrorTypeAbort, "Function not implemented.")); Shouldn't this fix be in ...
5 years, 3 months ago (2015-08-26 13:21:41 UTC) #3
yhirano
https://codereview.chromium.org/1308283002/diff/1/public/platform/modules/background_sync/WebSyncProvider.h File public/platform/modules/background_sync/WebSyncProvider.h (right): https://codereview.chromium.org/1308283002/diff/1/public/platform/modules/background_sync/WebSyncProvider.h#newcode54 public/platform/modules/background_sync/WebSyncProvider.h:54: callbacks->onError(WebSyncError(WebSyncError::ErrorTypeAbort, "Function not implemented.")); On 2015/08/26 13:21:41, jkarlin wrote: ...
5 years, 3 months ago (2015-08-27 02:23:05 UTC) #4
jkarlin
lgtm
5 years, 3 months ago (2015-08-27 11:25:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308283002/20001
5 years, 3 months ago (2015-08-27 18:50:39 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 19:31:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201330

Powered by Google App Engine
This is Rietveld 408576698