Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1740)

Unified Diff: Source/modules/background_sync/SyncCallbacks.h

Issue 1311053002: [BackgroundSync] Use appopriate type parameters for WebCallbacks (2/4) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/background_sync/SyncCallbacks.h
diff --git a/Source/modules/background_sync/SyncCallbacks.h b/Source/modules/background_sync/SyncCallbacks.h
index 689a87d30f91f4a1355c7c18dc21ea472135ae5b..23a5bbcaaa9d89d98bbb311585b5e3887567100e 100644
--- a/Source/modules/background_sync/SyncCallbacks.h
+++ b/Source/modules/background_sync/SyncCallbacks.h
@@ -31,8 +31,8 @@ public:
SyncRegistrationCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);
~SyncRegistrationCallbacks() override;
- void onSuccess(WebSyncRegistration*) override;
- void onError(WebSyncError*) override;
+ void onSuccess(WebPassOwnPtr<WebSyncRegistration>) override;
+ void onError(const WebSyncError&) override;
private:
Persistent<ScriptPromiseResolver> m_resolver;
@@ -50,8 +50,8 @@ public:
SyncNotifyWhenDoneCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);
~SyncNotifyWhenDoneCallbacks() override;
- void onSuccess(bool*) override;
- void onError(WebSyncError*) override;
+ void onSuccess(bool) override;
+ void onError(const WebSyncError&) override;
private:
Persistent<ScriptPromiseResolver> m_resolver;
@@ -69,8 +69,8 @@ public:
SyncUnregistrationCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);
~SyncUnregistrationCallbacks() override;
- void onSuccess(bool*) override;
- void onError(WebSyncError*) override;
+ void onSuccess(bool) override;
+ void onError(const WebSyncError&) override;
private:
Persistent<ScriptPromiseResolver> m_resolver;
@@ -87,8 +87,8 @@ public:
SyncGetRegistrationsCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);
~SyncGetRegistrationsCallbacks() override;
- void onSuccess(WebVector<WebSyncRegistration*>*) override;
- void onError(WebSyncError*) override;
+ void onSuccess(const WebVector<WebSyncRegistration*>&) override;
+ void onError(const WebSyncError&) override;
private:
Persistent<ScriptPromiseResolver> m_resolver;
@@ -104,8 +104,8 @@ public:
SyncGetPermissionStatusCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);
~SyncGetPermissionStatusCallbacks() override;
- void onSuccess(WebSyncPermissionStatus*) override;
- void onError(WebSyncError*) override;
+ void onSuccess(WebSyncPermissionStatus) override;
+ void onError(const WebSyncError&) override;
private:
static String permissionString(WebSyncPermissionStatus);
« no previous file with comments | « Source/modules/background_sync/PeriodicSyncRegistration.cpp ('k') | Source/modules/background_sync/SyncCallbacks.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698