Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1802)

Unified Diff: Source/modules/background_sync/PeriodicSyncRegistration.cpp

Issue 1311053002: [BackgroundSync] Use appopriate type parameters for WebCallbacks (2/4) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/background_sync/PeriodicSyncRegistration.cpp
diff --git a/Source/modules/background_sync/PeriodicSyncRegistration.cpp b/Source/modules/background_sync/PeriodicSyncRegistration.cpp
index 092da01b94407745901977bdc5ff78595073c1e4..b67ada9b89d5e5acda100f646667a1ec357792cb 100644
--- a/Source/modules/background_sync/PeriodicSyncRegistration.cpp
+++ b/Source/modules/background_sync/PeriodicSyncRegistration.cpp
@@ -20,12 +20,11 @@
namespace blink {
-PeriodicSyncRegistration* PeriodicSyncRegistration::take(ScriptPromiseResolver*, WebSyncRegistration* syncRegistration, ServiceWorkerRegistration* serviceWorkerRegistration)
+PeriodicSyncRegistration* PeriodicSyncRegistration::take(ScriptPromiseResolver*, PassOwnPtr<WebSyncRegistration> registration, ServiceWorkerRegistration* serviceWorkerRegistration)
{
- OwnPtr<WebSyncRegistration> registration = adoptPtr(syncRegistration);
PeriodicSyncRegistrationOptions options = PeriodicSyncRegistrationOptions();
- options.setMinPeriod(syncRegistration->minPeriodMs);
- switch (syncRegistration->networkState) {
+ options.setMinPeriod(registration->minPeriodMs);
+ switch (registration->networkState) {
case WebSyncRegistration::NetworkState::NetworkStateAny:
options.setNetworkState("any");
break;
@@ -36,7 +35,7 @@ PeriodicSyncRegistration* PeriodicSyncRegistration::take(ScriptPromiseResolver*,
options.setNetworkState("online");
break;
}
- switch (syncRegistration->powerState) {
+ switch (registration->powerState) {
case WebSyncRegistration::PowerState::PowerStateAuto:
options.setPowerState("auto");
break;
@@ -44,14 +43,8 @@ PeriodicSyncRegistration* PeriodicSyncRegistration::take(ScriptPromiseResolver*,
options.setPowerState("avoid-draining");
break;
}
- options.setTag(syncRegistration->tag);
- return new PeriodicSyncRegistration(syncRegistration->id, options, serviceWorkerRegistration);
-}
-
-void PeriodicSyncRegistration::dispose(WebSyncRegistration* syncRegistration)
-{
- if (syncRegistration)
- delete syncRegistration;
+ options.setTag(registration->tag);
+ return new PeriodicSyncRegistration(registration->id, options, serviceWorkerRegistration);
}
PeriodicSyncRegistration::PeriodicSyncRegistration(int64_t id, const PeriodicSyncRegistrationOptions& options, ServiceWorkerRegistration* serviceWorkerRegistration)
« no previous file with comments | « Source/modules/background_sync/PeriodicSyncRegistration.h ('k') | Source/modules/background_sync/SyncCallbacks.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698