Add ability for a BubbleReference to update the BubbleUI.

Add ability for a BubbleReference to update the BubbleUI.

BubbleManager doesn't always know when to update a bubble.
Ex: Bubble needs to change label from "Translating..." to "Translated".

Also fix naming from UI -> Ui

BUG=496955
Committed: https://crrev.com/3e2a58c20997a8ea9844f87b85e8566bc4286a5b
Cr-Commit-Position: refs/heads/master@{#347833}

[hcarmona, 2015-09-02 02:24:39]

hcarmona@chromium.org changed reviewers:
+ groby@chromium.org

[hcarmona, 2015-09-02 02:24:40]

PTAL

[groby-ooo-7-16, 2015-09-03 17:30:01]

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
File components/bubble/bubble_controller.cc (right):

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
components/bubble/bubble_controller.cc:28: return
manager_->UpdateBubbleUI(this->AsWeakPtr());
Does this need to flow through the manager? Who usually calls this?

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
components/bubble/bubble_controller.cc:55: bool
BubbleController::UpdateBubbleUIInternal() {
I decidedly dislike "Internal" functions. If we don't need to route through the
manager, this can go.

If we do, I think this should stay UpdateBubbleUi, and the public function
should become "RequestBubbleUiUpdate()"

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
File components/bubble/bubble_controller.h (right):

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
components/bubble/bubble_controller.h:27: bool UpdateBubbleUI();
Naming convention would make this UpdateBubbleUi. Each word starts with caps,
then lower case.

[hcarmona, 2015-09-03 18:05:54]

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
File components/bubble/bubble_controller.cc (right):

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
components/bubble/bubble_controller.cc:28: return
manager_->UpdateBubbleUI(this->AsWeakPtr());
On 2015/09/03 17:30:01, groby wrote:
> Does this need to flow through the manager? Who usually calls this?

Going through the manager ensures that we stay on the UI thread.

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
components/bubble/bubble_controller.cc:55: bool
BubbleController::UpdateBubbleUIInternal() {
On 2015/09/03 17:30:01, groby wrote:
> I decidedly dislike "Internal" functions. If we don't need to route through
the
> manager, this can go.
> 
> If we do, I think this should stay UpdateBubbleUi, and the public function
> should become "RequestBubbleUiUpdate()" 

Done.

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
File components/bubble/bubble_controller.h (right):

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
components/bubble/bubble_controller.h:27: bool UpdateBubbleUI();
On 2015/09/03 17:30:01, groby wrote:
> Naming convention would make this UpdateBubbleUi. Each word starts with caps,
> then lower case.

Fixed everywhere.

[groby-ooo-7-16, 2015-09-03 19:13:58]

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
File components/bubble/bubble_controller.cc (right):

https://codereview.chromium.org/1310483003/diff/1/components/bubble/bubble_co...
components/bubble/bubble_controller.cc:28: return
manager_->UpdateBubbleUI(this->AsWeakPtr());
On 2015/09/03 18:05:53, Hector Carmona wrote:
> On 2015/09/03 17:30:01, groby wrote:
> > Does this need to flow through the manager? Who usually calls this?
> 
> Going through the manager ensures that we stay on the UI thread.

Do we _need_ to ensure that? And if we do, let's ensure it in the controller.
(Because _it_ should certainly stay on the same thread as well)

[hcarmona, 2015-09-04 18:52:08]

UI thread checking is now in controller, which lets us get rid of having
to force the |UpdateUi| call through BubbleManager.

[groby-ooo-7-16, 2015-09-04 21:35:04]

lgtm

[hcarmona, 2015-09-08 23:07:56]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2015-09-08 23:08:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1310483003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1310483003/40001

[commit-bot: I haz the power, 2015-09-08 23:46:21]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-08 23:47:30]

Patchset 3 (id:??) landed as
https://crrev.com/3e2a58c20997a8ea9844f87b85e8566bc4286a5b
Cr-Commit-Position: refs/heads/master@{#347833}