Pass a BubbleReference to BubbleUI::Show.

Pass a BubbleReference to BubbleUI::Show.

Moved the BubbleReference to its own file to avoid having to include
bubble_manager.h everywhere.

The BubbleUI needs to be able to notify the bubble manager when it needs
to be closed.

BUG=496955
Committed: https://crrev.com/428ac3a45740d5d12d3e4ac7f248122f9b3c53c9
Cr-Commit-Position: refs/heads/master@{#347820}

[hcarmona, 2015-09-02 02:24:32]

hcarmona@chromium.org changed reviewers:
+ groby@chromium.org

[hcarmona, 2015-09-02 02:24:32]

PTAL

[groby-ooo-7-16, 2015-09-03 17:25:22]

I'm decidedly "meh" on factoring out bubble_reference.h - is that really such a
burden to include bubble_manager.h (and how many cases are there where we need a
reference, but not a manager?)

[hcarmona, 2015-09-03 17:37:38]

On 2015/09/03 17:25:22, groby wrote:
> I'm decidedly "meh" on factoring out bubble_reference.h - is that really such
a
> burden to include bubble_manager.h (and how many cases are there where we need
a
> reference, but not a manager?)

It's sometimes necessary to hold a reference to the bubble but not the
manager. So the reference ends up being a class member or a parameter,
but as long as you have a Browser it's possible to get the manager.
Basically makes it so we only need to include the manager in the cc/mm
files vs the headers too.

[hcarmona, 2015-09-08 20:36:26]

hcarmona@chromium.org changed reviewers:
+ rouslan@chromium.org

[hcarmona, 2015-09-08 20:36:27]

rouslan@ PTAL Thanks!

[please use gerrit instead, 2015-09-08 20:43:05]

https://codereview.chromium.org/1323133002/diff/1/components/bubble/bubble_ui.h
File components/bubble/bubble_ui.h (right):

https://codereview.chromium.org/1323133002/diff/1/components/bubble/bubble_ui...
components/bubble/bubble_ui.h:16: virtual void Show(BubbleReference
bubbleReference) = 0;
bubble_reference

[hcarmona, 2015-09-08 21:49:47]

https://codereview.chromium.org/1323133002/diff/1/components/bubble/bubble_ui.h
File components/bubble/bubble_ui.h (right):

https://codereview.chromium.org/1323133002/diff/1/components/bubble/bubble_ui...
components/bubble/bubble_ui.h:16: virtual void Show(BubbleReference
bubbleReference) = 0;
On 2015/09/08 20:43:05, Rouslan wrote:
> bubble_reference

Done.

[please use gerrit instead, 2015-09-08 22:40:02]

lgtm

[hcarmona, 2015-09-08 22:53:56]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2015-09-08 22:54:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1323133002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1323133002/20001

[commit-bot: I haz the power, 2015-09-08 23:01:03]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-08 23:01:57]

Patchset 2 (id:??) landed as
https://crrev.com/428ac3a45740d5d12d3e4ac7f248122f9b3c53c9
Cr-Commit-Position: refs/heads/master@{#347820}