components/bubble/bubble_delegate.cc - Issue 1310483003: Add ability for a BubbleReference to update the BubbleUI.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bubble/bubble_delegate.cc

Issue 1310483003: Add ability for a BubbleReference to update the BubbleUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bm-reference-own-file.gitbr

Patch Set: Add UI thread checks to controller Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/bubble/bubble_delegate.cc

diff --git a/components/bubble/bubble_delegate.cc b/components/bubble/bubble_delegate.cc

index 110d93f281cf506a2cb1aba0c8e20bc269fe0492..9c739060b884ea4d384601cdd47250190698e530 100644

--- a/components/bubble/bubble_delegate.cc

+++ b/components/bubble/bubble_delegate.cc

@@ -11,3 +11,7 @@ BubbleDelegate::~BubbleDelegate() {}

bool BubbleDelegate::ShouldClose(BubbleCloseReason reason) {

return true;

}

+bool BubbleDelegate::UpdateBubbleUi(BubbleUi* bubble_ui) {

+ return false;

« no previous file with comments | « components/bubble/bubble_delegate.h ('k') | components/bubble/bubble_manager_unittest.cc » ('j') | no next file with comments »