Add ability for a BubbleReference to update the BubbleUI.

components/bubble/bubble_controller.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/bubble/bubble_controller.h"
 
 #include "components/bubble/bubble_delegate.h"
 #include "components/bubble/bubble_manager.h"
 #include "components/bubble/bubble_ui.h"
 
 BubbleController::BubbleController(BubbleManager* manager,
                                    scoped_ptr<BubbleDelegate> delegate)
     : manager_(manager), delegate_(delegate.Pass()) {
   DCHECK(manager_);
   DCHECK(delegate_);
 }
 
 BubbleController::~BubbleController() {
   if (bubble_ui_)
     ShouldClose(BUBBLE_CLOSE_FORCED);
 }
 
 bool BubbleController::CloseBubble(BubbleCloseReason reason) {
   return manager_->CloseBubble(this->AsWeakPtr(), reason);
 }
 
+bool BubbleController::UpdateBubbleUI() {
+  return manager_->UpdateBubbleUI(this->AsWeakPtr());

[groby-ooo-7-16, 2015/09/03 17:30:01]

Does this need to flow through the manager? Who usually calls this?

[hcarmona, 2015/09/03 18:05:53]

Going through the manager ensures that we stay on the UI thread.

[groby-ooo-7-16, 2015/09/03 19:13:58]

Do we _need_ to ensure that? And if we do, let's ensure it in the controller.
(Because _it_ should certainly stay on the same thread as well)

+}
+
 void BubbleController::Show() {
   DCHECK(!bubble_ui_);
   bubble_ui_ = delegate_->BuildBubbleUI();
   DCHECK(bubble_ui_);
   bubble_ui_->Show(AsWeakPtr());
   // TODO(hcarmona): log that bubble was shown.
 }
 
 void BubbleController::UpdateAnchorPosition() {
   DCHECK(bubble_ui_);
   bubble_ui_->UpdateAnchorPosition();
 }
 
 bool BubbleController::ShouldClose(BubbleCloseReason reason) {
   DCHECK(bubble_ui_);
   if (delegate_->ShouldClose(reason) || reason == BUBBLE_CLOSE_FORCED) {
     bubble_ui_->Close();
     bubble_ui_.reset();
     // TODO(hcarmona): log that bubble was hidden.
     return true;
   }
   return false;
 }
+
+bool BubbleController::UpdateBubbleUIInternal() {

[groby-ooo-7-16, 2015/09/03 17:30:01]

I decidedly dislike "Internal" functions. If we don't need to route through the
manager, this can go.

If we do, I think this should stay UpdateBubbleUi, and the public function
should become "RequestBubbleUiUpdate()" 

[hcarmona, 2015/09/03 18:05:53]

Done.

+  if (!bubble_ui_)
+    return false;
+  return delegate_->UpdateBubbleUI(bubble_ui_.get());
+}