Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1305213009: Componentize PrefSyncableService and support classes. (Closed)

Created:
5 years, 3 months ago by sdefresne
Modified:
5 years, 3 months ago
CC:
aboxhall+watch_chromium.org, achuith+watch_chromium.org, asanka, benjhayden+dwatch_chromium.org, blundell+watchlist_chromium.org, blundell, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, derat+watch_chromium.org, devtools-reviews_chromium.org, dmazzoni+watch_chromium.org, droger+watchlist_chromium.org, dtseng+watch_chromium.org, dzhioev+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, felt, gcasto+watchlist_chromium.org, grt+watch_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, je_julie, kalyank, kinuko+fileapi, markusheintz_, maxbogue+watch_chromium.org, Matt Giuca, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-notifications_chromium.org, nektar+watch_chromium.org, nhiroki, nona+watch_chromium.org, noyau+watch_chromium.org, oshima+watch_chromium.org, pam+watch_chromium.org, peter+watch_chromium.org, pfeldman, plaree+watch_chromium.org, plundblad+watch_chromium.org, pvalenzuela+watch_chromium.org, raymes+watch_chromium.org, rginda+watch_chromium.org, rouslan+autofillwatch_chromium.org, sadrul, sdefresne+watchlist_chromium.org, shuchen+watch_chromium.org, stevenjb+watch_chromium.org, tapted, tfarina, tim+watch_chromium.org, tzik, vabr+watchlist_chromium.org, yurys, yusukes+watch_chromium.org, yuzo+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pref_service_syncable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize PrefSyncableService and support classes. Create components/syncable_prefs and move PrefSyncableService files, the support code and the unit tests. BUG=522544, 522537, 522536, 522532, 522530, 522527, 522526 Committed: https://crrev.com/875d078307b9c4da92f36b9d4d0d4de4a7d8c9be Cr-Commit-Position: refs/heads/master@{#349098}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove references to non-existent pref_model_associator_client.cc #

Patch Set 4 : Fix compilation with gn #

Patch Set 5 : Fix compilation with gn (test_only -> testonly) #

Patch Set 6 : Fix gn build (//sync/sync -> //sync) #

Patch Set 7 : Add missing dependency on //sync:test_support_sync_api for unit tests with gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+348 lines, -3025 lines) Patch
M chrome/browser/BUILD.gn View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_mapping_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/content_autofill_driver_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/managed_bookmark_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/customization/customization_document_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/events/event_rewriter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/first_run/first_run.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_syncer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_syncer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/consumer_enrollment_handler_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/power_prefs_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/preferences_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/profile_list_chromeos_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_policy_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/usb/android_rsa.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/download/chrome_download_manager_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_target_determiner_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_test_base.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/external_policy_loader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_pref_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_pref_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_provider_impl_chromeos_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_prefs.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/font_family_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/invalidation/invalidator_storage_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/chrome_network_delegate_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/ssl_config_service_manager_pref_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/notifications/extension_welcome_notification.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/notifications/extension_welcome_notification.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/notifications/extension_welcome_notification_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugins/plugin_info_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_model_associator_client.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store_proxy_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/incognito_mode_prefs_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_functional_browsertest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_metrics_service.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/pref_metrics_service.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/prefs/pref_model_associator.h View 1 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/browser/prefs/pref_model_associator.cc View 1 1 chunk +0 lines, -624 lines 0 comments Download
D chrome/browser/prefs/pref_model_associator_client.h View 1 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/prefs/pref_model_associator_unittest.cc View 1 1 chunk +0 lines, -472 lines 0 comments Download
D chrome/browser/prefs/pref_service_mock_factory.h View 1 chunk +0 lines, -20 lines 0 comments Download
D chrome/browser/prefs/pref_service_mock_factory.cc View 1 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/prefs/pref_service_syncable.h View 1 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/prefs/pref_service_syncable.cc View 1 1 chunk +0 lines, -182 lines 0 comments Download
D chrome/browser/prefs/pref_service_syncable_factory.h View 1 1 chunk +0 lines, -54 lines 0 comments Download
D chrome/browser/prefs/pref_service_syncable_factory.cc View 1 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/prefs/pref_service_syncable_observer.h View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/prefs/pref_service_syncable_unittest.cc View 1 1 chunk +0 lines, -741 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prefs/session_startup_pref_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/prefs/synced_pref_change_registrar.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/prefs/synced_pref_change_registrar.cc View 1 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/browser/prefs/synced_pref_observer.h View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/automatic_profile_resetter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/gaia_info_update_service_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_list_desktop_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/off_domain_inclusion_detector_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/platform_state_store_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/state_store_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/search_provider_install_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_factory_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/account_reconcilor_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/signin/cross_device_promo_factory.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/signin/cross_device_promo_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/local_auth_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_global_error_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/legacy/supervised_user_registration_utility_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/chrome_sync_client.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/search/suggestions/suggestions_search_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/app_list/speech_auth_helper_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/bookmarks/bookmark_tab_helper.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/cocoa_profile_test.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller_unittest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/search_engines/keyword_editor_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/profile_signin_confirmation_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 2 chunks +1 line, -11 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 5 chunks +2 lines, -6 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
D chrome/test/base/testing_pref_service_syncable.h View 1 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/test/base/testing_pref_service_syncable.cc View 1 1 chunk +0 lines, -72 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M components/components.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 3 chunks +6 lines, -0 lines 0 comments Download
M components/search_engines/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url_service_sync_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A components/syncable_prefs.gypi View 1 2 1 chunk +61 lines, -0 lines 0 comments Download
A components/syncable_prefs/BUILD.gn View 1 2 3 4 5 6 1 chunk +65 lines, -0 lines 0 comments Download
A components/syncable_prefs/DEPS View 1 chunk +11 lines, -0 lines 0 comments Download
A + components/syncable_prefs/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/syncable_prefs/pref_model_associator.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
A + components/syncable_prefs/pref_model_associator.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/syncable_prefs/pref_model_associator_client.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/syncable_prefs/pref_model_associator_unittest.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + components/syncable_prefs/pref_service_mock_factory.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/syncable_prefs/pref_service_mock_factory.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/syncable_prefs/pref_service_syncable.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
A + components/syncable_prefs/pref_service_syncable.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/syncable_prefs/pref_service_syncable_factory.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + components/syncable_prefs/pref_service_syncable_factory.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + components/syncable_prefs/pref_service_syncable_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/syncable_prefs/pref_service_syncable_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + components/syncable_prefs/synced_pref_change_registrar.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/syncable_prefs/synced_pref_change_registrar.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + components/syncable_prefs/synced_pref_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/syncable_prefs/testing_pref_service_syncable.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + components/syncable_prefs/testing_pref_service_syncable.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
sdefresne
gab: can you please review? blundell/mnissler: FYI This CL just introduce the component and move ...
5 years, 3 months ago (2015-09-09 11:52:31 UTC) #2
sdefresne
Bernard, can you take a look? Gab, this is for your information.
5 years, 3 months ago (2015-09-15 15:43:05 UTC) #5
Bernhard Bauer
lgtm
5 years, 3 months ago (2015-09-15 15:53:06 UTC) #6
sdefresne
zea@ can you review the new DEPS on src/sync from components/syncable_prefs?
5 years, 3 months ago (2015-09-15 15:54:28 UTC) #8
sdefresne
sky: can you approve the changes to //chrome? They are mechanical changes as I just ...
5 years, 3 months ago (2015-09-15 15:57:26 UTC) #10
Nicolas Zea
sync DEPS LGTM
5 years, 3 months ago (2015-09-15 20:13:19 UTC) #11
sky
Rubber stamp LGTM
5 years, 3 months ago (2015-09-15 22:12:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1305213009/110001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1305213009/110001
5 years, 3 months ago (2015-09-16 11:20:58 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:110001)
5 years, 3 months ago (2015-09-16 12:01:39 UTC) #16
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/875d078307b9c4da92f36b9d4d0d4de4a7d8c9be Cr-Commit-Position: refs/heads/master@{#349098}
5 years, 3 months ago (2015-09-16 12:02:11 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:54:38 UTC) #18
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/875d078307b9c4da92f36b9d4d0d4de4a7d8c9be
Cr-Commit-Position: refs/heads/master@{#349098}

Powered by Google App Engine
This is Rietveld 408576698