chrome/browser/notifications/extension_welcome_notification.cc - Issue 1305213009: Componentize PrefSyncableService and support classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/extension_welcome_notification.cc

Issue 1305213009: Componentize PrefSyncableService and support classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pref_service_syncable

Patch Set: Add missing dependency on //sync:test_support_sync_api for unit tests with gn Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/extension_welcome_notification.h ('k') | chrome/browser/notifications/extension_welcome_notification_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/extension_welcome_notification.cc

diff --git a/chrome/browser/notifications/extension_welcome_notification.cc b/chrome/browser/notifications/extension_welcome_notification.cc

index b138c7ac4cb48fce02330f39ddf8705963473627..7ea0bb7a6ff06d6c6978acafd117208e1af491c4 100644

--- a/chrome/browser/notifications/extension_welcome_notification.cc

+++ b/chrome/browser/notifications/extension_welcome_notification.cc

@@ -13,7 +13,6 @@

#include "base/thread_task_runner_handle.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/notifications/notification.h"

-#include "chrome/browser/prefs/pref_service_syncable.h"

#include "chrome/browser/prefs/pref_service_syncable_util.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/ui/browser_navigator.h"

@@ -21,6 +20,7 @@

#include "chrome/common/url_constants.h"

#include "chrome/grit/generated_resources.h"

#include "components/pref_registry/pref_registry_syncable.h"

+#include "components/syncable_prefs/pref_service_syncable.h"

#include "grit/theme_resources.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/resource/resource_bundle.h"