chrome/browser/prefs/chrome_pref_service_factory.cc - Issue 1305213009: Componentize PrefSyncableService and support classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/chrome_pref_service_factory.cc

Issue 1305213009: Componentize PrefSyncableService and support classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pref_service_syncable

Patch Set: Add missing dependency on //sync:test_support_sync_api for unit tests with gn Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/prefs/chrome_pref_model_associator_client.h ('k') | chrome/browser/prefs/chrome_pref_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/chrome_pref_service_factory.cc

diff --git a/chrome/browser/prefs/chrome_pref_service_factory.cc b/chrome/browser/prefs/chrome_pref_service_factory.cc

index 92dd2818aeb5ebdcc3edab16dfb3b366172512ff..c1935c9b11fee960a7f079dc7ec5114d457c24fc 100644

--- a/chrome/browser/prefs/chrome_pref_service_factory.cc

+++ b/chrome/browser/prefs/chrome_pref_service_factory.cc

@@ -27,9 +27,6 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/prefs/chrome_pref_model_associator_client.h"

#include "chrome/browser/prefs/command_line_pref_store.h"

-#include "chrome/browser/prefs/pref_model_associator.h"

-#include "chrome/browser/prefs/pref_service_syncable.h"

-#include "chrome/browser/prefs/pref_service_syncable_factory.h"

#include "chrome/browser/prefs/profile_pref_store_manager.h"

#include "chrome/browser/profiles/file_path_verifier_win.h"

#include "chrome/browser/profiles/profile.h"

@@ -45,6 +42,9 @@

#include "components/search_engines/default_search_pref_migration.h"

#include "components/search_engines/search_engines_pref_names.h"

#include "components/sync_driver/pref_names.h"

+#include "components/syncable_prefs/pref_model_associator.h"

+#include "components/syncable_prefs/pref_service_syncable.h"

+#include "components/syncable_prefs/pref_service_syncable_factory.h"

#include "components/user_prefs/tracked/pref_names.h"

#include "content/public/browser/browser_context.h"

#include "content/public/browser/browser_thread.h"

« no previous file with comments | « chrome/browser/prefs/chrome_pref_model_associator_client.h ('k') | chrome/browser/prefs/chrome_pref_service_unittest.cc » ('j') | no next file with comments »