chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc - Issue 1305213009: Componentize PrefSyncableService and support classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

Issue 1305213009: Componentize PrefSyncableService and support classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pref_service_syncable

Patch Set: Add missing dependency on //sync:test_support_sync_api for unit tests with gn Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/users/multi_profile_user_controller_unittest.cc ('k') | chrome/browser/chromeos/policy/consumer_enrollment_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

index bb0b20d0b5b9dc4c2160dac5a30df7e335c3b8e6..0d395b55ed9913865b53e24c878da6cf1cebc544 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

+++ b/chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc

@@ -14,7 +14,6 @@

#include "chrome/browser/chromeos/net/network_portal_detector_impl.h"

#include "chrome/browser/chromeos/net/network_portal_detector_test_utils.h"

#include "chrome/browser/chromeos/net/network_portal_notification_controller.h"

-#include "chrome/browser/prefs/pref_service_syncable.h"

#include "chrome/browser/profiles/profile.h"

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/common/pref_names.h"

@@ -24,6 +23,7 @@

#include "chromeos/network/portal_detector/network_portal_detector.h"

#include "chromeos/network/portal_detector/network_portal_detector_strategy.h"

#include "components/captive_portal/captive_portal_testing_utils.h"

+#include "components/syncable_prefs/pref_service_syncable.h"

#include "content/public/test/test_utils.h"

#include "dbus/object_path.h"

#include "net/base/net_errors.h"