chrome/browser/prefs/browser_prefs.cc - Issue 1305213009: Componentize PrefSyncableService and support classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prefs/browser_prefs.cc

Issue 1305213009: Componentize PrefSyncableService and support classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pref_service_syncable

Patch Set: Add missing dependency on //sync:test_support_sync_api for unit tests with gn Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc ('k') | chrome/browser/prefs/chrome_pref_model_associator_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/prefs/browser_prefs.cc

diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc

index 0e55d16393a6242f88eecdd44aacabff661ffa6a..4b5f8b57605b0c245e1b573d5339f4bd34f50d60 100644

--- a/chrome/browser/prefs/browser_prefs.cc

+++ b/chrome/browser/prefs/browser_prefs.cc

@@ -43,7 +43,6 @@

#include "chrome/browser/plugins/plugin_finder.h"

#include "chrome/browser/prefs/chrome_pref_service_factory.h"

#include "chrome/browser/prefs/incognito_mode_prefs.h"

-#include "chrome/browser/prefs/pref_service_syncable.h"

#include "chrome/browser/prefs/session_startup_pref.h"

#include "chrome/browser/profiles/chrome_version_service.h"

#include "chrome/browser/profiles/profile.h"

@@ -87,6 +86,7 @@

#include "components/rappor/rappor_service.h"

#include "components/search_engines/template_url_prepopulate_data.h"

#include "components/sync_driver/sync_prefs.h"

+#include "components/syncable_prefs/pref_service_syncable.h"

#include "components/translate/core/browser/translate_prefs.h"

#include "components/variations/service/variations_service.h"

#include "components/web_resource/promo_resource_service.h"