chrome/browser/signin/cross_device_promo_unittest.cc - Issue 1305213009: Componentize PrefSyncableService and support classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/cross_device_promo_unittest.cc

Issue 1305213009: Componentize PrefSyncableService and support classes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pref_service_syncable

Patch Set: Add missing dependency on //sync:test_support_sync_api for unit tests with gn Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/cross_device_promo_factory.cc ('k') | chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/cross_device_promo_unittest.cc

diff --git a/chrome/browser/signin/cross_device_promo_unittest.cc b/chrome/browser/signin/cross_device_promo_unittest.cc

index fb2827d899658ad9ad8d9171adcf3c6d36435a9d..aa7b51b0ecb4d330e8579377dbe6d1623ab914ad 100644

--- a/chrome/browser/signin/cross_device_promo_unittest.cc

+++ b/chrome/browser/signin/cross_device_promo_unittest.cc

@@ -8,7 +8,6 @@

#include "base/run_loop.h"

#include "base/test/histogram_tester.h"

#include "chrome/browser/prefs/browser_prefs.h"

-#include "chrome/browser/prefs/pref_service_syncable.h"

#include "chrome/browser/signin/chrome_signin_client_factory.h"

#include "chrome/browser/signin/cross_device_promo_factory.h"

#include "chrome/browser/signin/fake_gaia_cookie_manager_service.h"

@@ -18,12 +17,13 @@

#include "chrome/browser/signin/test_signin_client_builder.h"

#include "chrome/common/pref_names.h"

#include "chrome/test/base/testing_browser_process.h"

-#include "chrome/test/base/testing_pref_service_syncable.h"

#include "chrome/test/base/testing_profile.h"

#include "chrome/test/base/testing_profile_manager.h"

#include "components/signin/core/browser/signin_manager.h"

#include "components/signin/core/browser/signin_metrics.h"

#include "components/signin/core/browser/test_signin_client.h"

+#include "components/syncable_prefs/pref_service_syncable.h"

+#include "components/syncable_prefs/testing_pref_service_syncable.h"

#include "components/variations/entropy_provider.h"

#include "components/variations/variations_associated_data.h"

#include "content/public/test/test_browser_thread_bundle.h"