[#5] Pass gfx structs by const ref (gfx::Vector2dF)

Pass gfx structs by const ref (gfx::Vector2dF)
Avoid unneccessary copy of structures gfx::Vector2dF
by passing them by const ref rather than value.

Any struct of size > 4 bytes should be passed by const ref.
Passing by ref for these structs is faster than passing
by value, especially when invoking function has multiple parameters.


Pass gfx structs by const ref (gfx::Vector2dF)

BUG=159273
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246563

[r.kasibhatla, 2014-01-21 10:28:03]

Correct the given files.

https://codereview.chromium.org/130443005/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/130443005/diff/1/AUTHORS#newcode17
AUTHORS:17: Ajay Berwal <ajay.berwal@samsung.com>
Have you signed the CLA? If not, check with Prashant and send a mail to Laszlo
for adding you into CLA. It should happen quick enough.

https://codereview.chromium.org/130443005/diff/1/cc/input/input_handler.h
File cc/input/input_handler.h (right):

https://codereview.chromium.org/130443005/diff/1/cc/input/input_handler.h#new...
cc/input/input_handler.h:98: virtual void NotifyCurrentFlingVelocity(const
gfx::Vector2dF& velocity) = 0;
Missed overriding the function in following files
1. content/renderer/input/input_handler_proxy_unittest.cc

https://codereview.chromium.org/130443005/diff/1/cc/input/layer_scroll_offset...
File cc/input/layer_scroll_offset_delegate.h (right):

https://codereview.chromium.org/130443005/diff/1/cc/input/layer_scroll_offset...
cc/input/layer_scroll_offset_delegate.h:23: 
Missed overriding the function in following files:
1. content/browser/android/in_process/synchronous_compositor_impl.h
2. content/browser/android/in_process/synchronous_compositor_impl.cc

You might also need to check the SetMaxScrollOffset in layer_impl.h/.cc. It
seems it is wrong that in param is gfx::Vector2d but passing & storing param is
gfx::Vector2dF. It might need to be corrected.

https://codereview.chromium.org/130443005/diff/1/cc/input/layer_scroll_offset...
cc/input/layer_scroll_offset_delegate.h:26: virtual void
SetTotalScrollOffset(const gfx::Vector2dF& new_value) = 0;
Missed overriding the following files:
1. content/browser/android/in_process/synchronous_compositor_impl.h
2. content/browser/android/in_process/synchronous_compositor_impl.cc

[prashant.n, 2014-01-21 11:29:04]

Change the subject line with patch counter, e.g. [#5]

[prashant.n, 2014-01-22 09:23:23]

PTAL

[prashant.n, 2014-01-22 09:30:26]

Adding bulach@ for synchronous_compositor_impl.h and
synchronous_compositor_impl.cc

Adding jdduke@ for input_handler_proxy_unittest.cc

[Berwal, 2014-01-22 14:24:40]

i have fixed all the compiler issues...now PTAL

[danakj, 2014-01-22 17:39:42]

LGTM

https://codereview.chromium.org/130443005/diff/140019/content/renderer/input/...
File content/renderer/input/input_handler_proxy_unittest.cc (left):

https://codereview.chromium.org/130443005/diff/140019/content/renderer/input/...
content/renderer/input/input_handler_proxy_unittest.cc:80: 
keep this line?

[jdduke (slow), 2014-01-22 18:07:27]

content/renderer/input/input_handler_proxy_unittest.cc lgtm with nit.

https://codereview.chromium.org/130443005/diff/140019/content/renderer/input/...
File content/renderer/input/input_handler_proxy_unittest.cc (right):

https://codereview.chromium.org/130443005/diff/140019/content/renderer/input/...
content/renderer/input/input_handler_proxy_unittest.cc:51: const gfx::Vector2dF&
scroll_delta));
Nit: Please align the second arg with the first (indent 2 more spaces).

[Berwal, 2014-01-23 08:59:06]

On 2014/01/22 17:39:42, danakj wrote:
> LGTM
> 
>
https://codereview.chromium.org/130443005/diff/140019/content/renderer/input/...
> File content/renderer/input/input_handler_proxy_unittest.cc (left):
> 
>
https://codereview.chromium.org/130443005/diff/140019/content/renderer/input/...
> content/renderer/input/input_handler_proxy_unittest.cc:80: 
> keep this line?

DONE.

[Berwal, 2014-01-23 08:59:29]

On 2014/01/22 17:39:42, danakj wrote:
> LGTM
> 
>
https://codereview.chromium.org/130443005/diff/140019/content/renderer/input/...
> File content/renderer/input/input_handler_proxy_unittest.cc (left):
> 
>
https://codereview.chromium.org/130443005/diff/140019/content/renderer/input/...
> content/renderer/input/input_handler_proxy_unittest.cc:80: 
> keep this line?

DONE.

[commit-bot: I haz the power, 2014-01-23 09:00:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ajay.berwal@samsung.com/130443005/60002

[commit-bot: I haz the power, 2014-01-23 10:39:20]

Change committed as 246563