Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: cc/input/layer_scroll_offset_delegate.h

Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated the review comments Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/input/input_handler.h ('k') | cc/input/page_scale_animation.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_INPUT_LAYER_SCROLL_OFFSET_DELEGATE_H_ 5 #ifndef CC_INPUT_LAYER_SCROLL_OFFSET_DELEGATE_H_
6 #define CC_INPUT_LAYER_SCROLL_OFFSET_DELEGATE_H_ 6 #define CC_INPUT_LAYER_SCROLL_OFFSET_DELEGATE_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "ui/gfx/size_f.h" 9 #include "ui/gfx/size_f.h"
10 #include "ui/gfx/vector2d_f.h" 10 #include "ui/gfx/vector2d_f.h"
11 11
12 namespace cc { 12 namespace cc {
13 13
14 // The LayerScrollOffsetDelegate allows for the embedder to take ownership of 14 // The LayerScrollOffsetDelegate allows for the embedder to take ownership of
15 // the scroll offset of the root layer. 15 // the scroll offset of the root layer.
16 // 16 //
17 // The LayerScrollOffsetDelegate is only used on the impl thread. 17 // The LayerScrollOffsetDelegate is only used on the impl thread.
18 class LayerScrollOffsetDelegate { 18 class LayerScrollOffsetDelegate {
19 public: 19 public:
20 // This is called by the compositor to notify the delegate what is the upper 20 // This is called by the compositor to notify the delegate what is the upper
21 // total scroll offset bound. 21 // total scroll offset bound.
22 virtual void SetMaxScrollOffset(gfx::Vector2dF max_scroll_offset) = 0; 22 virtual void SetMaxScrollOffset(const gfx::Vector2dF& max_scroll_offset) = 0;
23 23
24 // This is called by the compositor when the scroll offset of the layer would 24 // This is called by the compositor when the scroll offset of the layer would
25 // have otherwise changed. 25 // have otherwise changed.
26 virtual void SetTotalScrollOffset(gfx::Vector2dF new_value) = 0; 26 virtual void SetTotalScrollOffset(const gfx::Vector2dF& new_value) = 0;
27 27
28 // This is called by the compositor to query the current scroll offset of the 28 // This is called by the compositor to query the current scroll offset of the
29 // layer. 29 // layer.
30 // There is no requirement that the return values of this method are 30 // There is no requirement that the return values of this method are
31 // stable in time (two subsequent calls may yield different results). 31 // stable in time (two subsequent calls may yield different results).
32 // The return value is not required to be related to the values passed in to 32 // The return value is not required to be related to the values passed in to
33 // the SetTotalScrollOffset method in any way however it is required to be no 33 // the SetTotalScrollOffset method in any way however it is required to be no
34 // more than the value passed to the most recent SetMaxScrollOffset call. 34 // more than the value passed to the most recent SetMaxScrollOffset call.
35 virtual gfx::Vector2dF GetTotalScrollOffset() = 0; 35 virtual gfx::Vector2dF GetTotalScrollOffset() = 0;
36 36
(...skipping 13 matching lines...) Expand all
50 LayerScrollOffsetDelegate() {} 50 LayerScrollOffsetDelegate() {}
51 virtual ~LayerScrollOffsetDelegate() {} 51 virtual ~LayerScrollOffsetDelegate() {}
52 52
53 private: 53 private:
54 DISALLOW_COPY_AND_ASSIGN(LayerScrollOffsetDelegate); 54 DISALLOW_COPY_AND_ASSIGN(LayerScrollOffsetDelegate);
55 }; 55 };
56 56
57 } // namespace cc 57 } // namespace cc
58 58
59 #endif // CC_INPUT_LAYER_SCROLL_OFFSET_DELEGATE_H_ 59 #endif // CC_INPUT_LAYER_SCROLL_OFFSET_DELEGATE_H_
OLDNEW
« no previous file with comments | « cc/input/input_handler.h ('k') | cc/input/page_scale_animation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698