content/browser/android/in_process/synchronous_compositor_impl.cc - Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/in_process/synchronous_compositor_impl.cc

Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated the review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/in_process/synchronous_compositor_impl.cc

diff --git a/content/browser/android/in_process/synchronous_compositor_impl.cc b/content/browser/android/in_process/synchronous_compositor_impl.cc

index 24299d518e6d5c45319ade90dc9422c93fcd9d0c..95289805afaedbf1cb546e0e713e6ad4362f7571 100644

--- a/content/browser/android/in_process/synchronous_compositor_impl.cc

+++ b/content/browser/android/in_process/synchronous_compositor_impl.cc

@@ -212,13 +212,14 @@ void SynchronousCompositorImpl::DidActivatePendingTree() {

}

void SynchronousCompositorImpl::SetMaxScrollOffset(

- gfx::Vector2dF max_scroll_offset) {

+ const gfx::Vector2dF& max_scroll_offset) {

DCHECK(CalledOnValidThread());

if (compositor_client_)

compositor_client_->SetMaxRootLayerScrollOffset(max_scroll_offset);

}

-void SynchronousCompositorImpl::SetTotalScrollOffset(gfx::Vector2dF new_value) {

+void SynchronousCompositorImpl::SetTotalScrollOffset(

+ const gfx::Vector2dF& new_value) {

DCHECK(CalledOnValidThread());

if (compositor_client_)

compositor_client_->SetTotalRootLayerScrollOffset(new_value);