cc/animation/layer_animation_value_observer.h - Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/layer_animation_value_observer.h

Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated the review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/animation/layer_animation_value_observer.h

diff --git a/cc/animation/layer_animation_value_observer.h b/cc/animation/layer_animation_value_observer.h

index d21ade80f4851ea086fb94e41dc78ba26e043c06..e09180620f67a0dd4e4ad83b43df1678171547cd 100644

--- a/cc/animation/layer_animation_value_observer.h

+++ b/cc/animation/layer_animation_value_observer.h

@@ -16,7 +16,7 @@ class CC_EXPORT LayerAnimationValueObserver {

virtual void OnFilterAnimated(const FilterOperations& filters) = 0;

virtual void OnOpacityAnimated(float opacity) = 0;

virtual void OnTransformAnimated(const gfx::Transform& transform) = 0;

- virtual void OnScrollOffsetAnimated(gfx::Vector2dF scroll_offset) = 0;

+ virtual void OnScrollOffsetAnimated(const gfx::Vector2dF& scroll_offset) = 0;

virtual void OnAnimationWaitingForDeletion() = 0;

virtual bool IsActive() const = 0;

};