[#5] Pass gfx structs by const ref (gfx::Vector2dF)

content/renderer/input/input_handler_proxy_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/input/input_handler_proxy.h"
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "cc/base/swap_promise_monitor.h"
 #include "content/renderer/input/input_handler_proxy_client.h"
@@ skipping 29 matching lines @@
   MOCK_METHOD2(PinchGestureUpdate,
                void(float magnify_delta, gfx::Point anchor));
   MOCK_METHOD0(PinchGestureEnd, void());
 
   MOCK_METHOD0(ScheduleAnimation, void());
 
   MOCK_METHOD2(ScrollBegin,
                ScrollStatus(gfx::Point viewport_point,
                             cc::InputHandler::ScrollInputType type));
   MOCK_METHOD2(ScrollBy,
-               bool(gfx::Point viewport_point, gfx::Vector2dF scroll_delta));
+               bool(gfx::Point viewport_point,
+                  const gfx::Vector2dF& scroll_delta));

[jdduke (slow), 2014/01/22 18:07:28]

Nit: Please align the second arg with the first (indent 2 more spaces).

   MOCK_METHOD2(ScrollVerticallyByPage,
                bool(gfx::Point viewport_point,
                     cc::ScrollDirection direction));
   MOCK_METHOD0(ScrollEnd, void());
   MOCK_METHOD0(FlingScrollBegin, cc::InputHandler::ScrollStatus());
 
   virtual scoped_ptr<cc::SwapPromiseMonitor>
     CreateLatencyInfoSwapPromiseMonitor(ui::LatencyInfo* latency) OVERRIDE {
       return scoped_ptr<cc::SwapPromiseMonitor>();
   }
 
   virtual void BindToClient(cc::InputHandlerClient* client) OVERRIDE {}
 
   virtual void StartPageScaleAnimation(gfx::Vector2d target_offset,
                                        bool anchor_point,
                                        float page_scale,
                                        base::TimeDelta duration) OVERRIDE {}
 
-  virtual void NotifyCurrentFlingVelocity(gfx::Vector2dF velocity) OVERRIDE {}
+  virtual void NotifyCurrentFlingVelocity(
+      const gfx::Vector2dF& velocity) OVERRIDE {}
   virtual void MouseMoveAt(gfx::Point mouse_position) OVERRIDE {}
 
   MOCK_METHOD1(HaveTouchEventHandlersAt,
                bool(gfx::Point point));
 
   virtual void SetRootLayerScrollOffsetDelegate(
       cc::LayerScrollOffsetDelegate* root_layer_scroll_offset_delegate)
       OVERRIDE {}
 
   virtual void OnRootLayerDelegatedScrollOffsetChanged() OVERRIDE {}
-

[danakj, 2014/01/22 17:39:43]

keep this line?

   DISALLOW_COPY_AND_ASSIGN(MockInputHandler);
 };
 
 // A simple WebGestureCurve implementation that flings at a constant velocity
 // indefinitely.
 class FakeWebGestureCurve : public blink::WebGestureCurve {
  public:
   FakeWebGestureCurve(const blink::WebFloatPoint& velocity,
                       const blink::WebSize& cumulative_scroll)
       : velocity_(velocity), cumulative_scroll_(cumulative_scroll) {}
@@ skipping 1123 matching lines @@
 
   touch.touches[2].state = WebTouchPoint::StatePressed;
   touch.touches[2].screenPosition = WebPoint(-10, 10);
   touch.touches[2].position = WebPoint(-10, 10);
 
   EXPECT_EQ(expected_disposition_, input_handler_->HandleInputEvent(touch));
 }
 
 } // namespace
 } // namespace content