Fix various errorprone warnings and errors.

Fix various errorprone warnings and errors.

http://errorprone.info/bugpattern/SynchronizeOnNonFinalField
android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java
android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java
android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java
base/test/android/javatests/src/org/chromium/base/test/util/TestThread.java
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GoogleCloudMessagingV2.java
content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java
remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
remoting/android/java/src/org/chromium/chromoting/DesktopView.java
remoting/android/java/src/org/chromium/chromoting/TrackingInputHandler.java

http://errorprone.info/bugpattern/ElementsCountedInLoop
base/android/javatests/src/org/chromium/base/ObserverListTest.java

http://errorprone.info/bugpattern/TypeParameterUnusedInFormals
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java

http://errorprone.info/bugpattern/NarrowingCompoundAssignment
chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java

http://errorprone.info/bugpattern/WaitNotInLoop
chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java

BUG=485599
Committed: https://crrev.com/24d909795c9c17c8d1b26ae041a40a28f321900e
Cr-Commit-Position: refs/heads/master@{#344840}

[mikecase (-- gone --), 2015-08-18 01:32:53]

mikecase@chromium.org changed reviewers:
+ garykac@chromium.org, johnme@chromium.org, nyquist@chromium.org,
tedchoc@chromium.org, torne@chromium.org

[mikecase (-- gone --), 2015-08-18 01:32:54]

We want to start using the error-prone compiler which finds a bunch of java
errors at compile-time. Fixing some various warnings and errors it found before
we enable it.

+torne@chromium.org for review of android_webview/*
+nyquist@chromium.org for review of base/* and chrome/*
+johnme@chromium.org for review of components/gcm_driver/android/*
+tedchoc@chromium.org for review of content/public/android/*
+garykac@chromium.org for review of remoting/android/*

[tfarina, 2015-08-18 01:51:21]

Are the open source versions of those errorprone.info urls?

[Torne, 2015-08-18 10:16:44]

android_webview LGTM

[Lambros, 2015-08-18 18:17:33]

lambroslambrou@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[Lambros, 2015-08-18 18:17:34]

lgtm for remoting/android

[nyquist, 2015-08-19 09:51:33]

https://codereview.chromium.org/1297073004/diff/40001/base/android/javatests/...
File base/android/javatests/src/org/chromium/base/ObserverListTest.java (right):

https://codereview.chromium.org/1297073004/diff/40001/base/android/javatests/...
base/android/javatests/src/org/chromium/base/ObserverListTest.java:73:
@SuppressWarnings("ElementsCountedInLoop")
Optional nit: I guess you could technically add an early return here along the
lines of:
if (iterable instanceof Collection) return (Collection<?> iterable).size();

https://codereview.chromium.org/1297073004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java
(right):

https://codereview.chromium.org/1297073004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java:174:
private static <T extends Object> T chromeBrowserProviderCall(Class returnType,
String name,
Could this instead of suppressing the warning be Class<T>?

https://codereview.chromium.org/1297073004/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java
(right):

https://codereview.chromium.org/1297073004/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java:47:
@SuppressWarnings("WaitNotInLoop")
This seems dubious to me. Given the possible spurious wakeups, it's not
guaranteed that the wait() call will in fact ensure that the condition is
satisfied. Shouldn't we instead also set a flag in onAnimationEnd(...)? And
AtomicBoolean for example should be able to be used easily, and then in the
wait()-places, you'd add a loop to verify the state (and a timeout I guess).

[mikecase (-- gone --), 2015-08-19 23:15:08]

Addressed nyquist's comments.
Made two minor changes to CardboardDesktopRenderer.java, as some additional
errors appeared up after rebase.

https://codereview.chromium.org/1297073004/diff/40001/base/android/javatests/...
File base/android/javatests/src/org/chromium/base/ObserverListTest.java (right):

https://codereview.chromium.org/1297073004/diff/40001/base/android/javatests/...
base/android/javatests/src/org/chromium/base/ObserverListTest.java:73:
@SuppressWarnings("ElementsCountedInLoop")
On 2015/08/19 at 09:51:33, nyquist (OOO - back 8-24) wrote:
> Optional nit: I guess you could technically add an early return here along the
lines of:
> if (iterable instanceof Collection) return (Collection<?> iterable).size();

Done

https://codereview.chromium.org/1297073004/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java
(right):

https://codereview.chromium.org/1297073004/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java:174:
private static <T extends Object> T chromeBrowserProviderCall(Class returnType,
String name,
On 2015/08/19 at 09:51:33, nyquist (OOO - back 8-24) wrote:
> Could this instead of suppressing the warning be Class<T>?

Done

https://codereview.chromium.org/1297073004/diff/40001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java
(right):

https://codereview.chromium.org/1297073004/diff/40001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java:47:
@SuppressWarnings("WaitNotInLoop")
On 2015/08/19 at 09:51:33, nyquist (OOO - back 8-24) wrote:
> This seems dubious to me. Given the possible spurious wakeups, it's not
guaranteed that the wait() call will in fact ensure that the condition is
satisfied. Shouldn't we instead also set a flag in onAnimationEnd(...)? And
AtomicBoolean for example should be able to be used easily, and then in the
wait()-places, you'd add a loop to verify the state (and a timeout I guess).

Done

https://codereview.chromium.org/1297073004/diff/80001/remoting/android/java/s...
File
remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
(right):

https://codereview.chromium.org/1297073004/diff/80001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java:186:
private final Object mCameraPositionLock = new Object();
fyi, for lambroslambrou@chromium.org. I synced and rebased this CL and a few
additional errorprone errors popped up. Same changes as before, just made
mLoadSkyboxImagesTextureLock and mCameraPositionLock final.

[Lambros, 2015-08-19 23:42:02]

https://codereview.chromium.org/1297073004/diff/80001/remoting/android/java/s...
File
remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
(right):

https://codereview.chromium.org/1297073004/diff/80001/remoting/android/java/s...
remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java:186:
private final Object mCameraPositionLock = new Object();
On 2015/08/19 23:15:08, mikecase wrote:
> fyi, for mailto:lambroslambrou@chromium.org. I synced and rebased this CL and
a few
> additional errorprone errors popped up. Same changes as before, just made
> mLoadSkyboxImagesTextureLock and mCameraPositionLock final.

Sorry for the noise - we're actively working on this code. We'll try to avoid
non-final locks from now on :)

[nyquist, 2015-08-20 01:32:19]

base/* and chrome/* lgtm

[johnme, 2015-08-20 12:46:49]

components/gcm_driver/ lgtm

[Ted C, 2015-08-21 16:52:36]

On 2015/08/20 12:46:49, johnme wrote:
> components/gcm_driver/ lgtm

content/public/android/ - lgtm

[mikecase (-- gone --), 2015-08-21 17:23:43]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2015-08-21 17:23:43]

The patchset sent to the CQ was uploaded after l-g-t-m from torne@chromium.org,
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/1297073004/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-08-21 17:24:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297073004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297073004/80001

[commit-bot: I haz the power, 2015-08-21 17:27:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 17:27:12]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mikecase (-- gone --), 2015-08-21 17:45:50]

The CQ bit was checked by mikecase@chromium.org

[mikecase (-- gone --), 2015-08-21 17:45:50]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org,
torne@chromium.org, lambroslambrou@chromium.org, tedchoc@chromium.org,
nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1297073004/#ps100001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-08-21 17:47:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1297073004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1297073004/100001

[commit-bot: I haz the power, 2015-08-21 19:47:23]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-08-21 19:48:03]

Patchset 6 (id:??) landed as
https://crrev.com/24d909795c9c17c8d1b26ae041a40a28f321900e
Cr-Commit-Position: refs/heads/master@{#344840}