android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java - Issue 1297073004: Fix various errorprone warnings and errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java

Issue 1297073004: Fix various errorprone warnings and errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java ('k') | base/android/javatests/src/org/chromium/base/ObserverListTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java b/android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java

index f194853259b34d0f308ed8214803d6a599e85bd3..c599ecc20253ee3808f38e5448cfc66aeb3bf0a5 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java

@@ -15,7 +15,7 @@ import org.chromium.content.browser.ContentViewCore;

* 3. In javascript call notifyJava() when you want Java side know something is done.

public class JavascriptEventObserver {

- private Object mEvent = new Object();

+ private final Object mEvent = new Object();

private boolean mHappened;

/**