Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2797)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/DesktopView.java

Issue 1297073004: Fix various errorprone warnings and errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/DesktopView.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/DesktopView.java b/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
index 0b7dc1dfbb2496ba24f4fc4a6f2faec54f4893fb..5151559b0adcf5ef83509fd5827c58db46bf272f 100644
--- a/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
+++ b/remoting/android/java/src/org/chromium/chromoting/DesktopView.java
@@ -34,7 +34,7 @@ import org.chromium.chromoting.jni.JniInterface;
/** GUI element that holds the drawing canvas. */
public class DesktopView extends SurfaceView implements DesktopViewInterface,
SurfaceHolder.Callback {
- private RenderData mRenderData;
+ private final RenderData mRenderData;
private TouchInputHandler mInputHandler;
/** The parent Desktop activity. */
@@ -61,7 +61,7 @@ public class DesktopView extends SurfaceView implements DesktopViewInterface,
private boolean mRunning = false;
/** Lock to allow multithreaded access to {@link #mStartTime} and {@link #mRunning}. */
- private Object mLock = new Object();
+ private final Object mLock = new Object();
private Paint mPaint = new Paint();
@@ -115,7 +115,7 @@ public class DesktopView extends SurfaceView implements DesktopViewInterface,
// Variables to control animation by the TouchInputHandler.
/** Protects mInputAnimationRunning. */
- private Object mAnimationLock = new Object();
+ private final Object mAnimationLock = new Object();
/** Whether the TouchInputHandler has requested animation to be performed. */
private boolean mInputAnimationRunning = false;

Powered by Google App Engine
This is Rietveld 408576698